mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Jonathan Richardson <jonathan.richardson@broadcom.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Mark Rutland <mark.rutland@arm.com>,
	Scott Branden <sbranden@broadcom.com>,
	Ray Jui <rjui@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Jonathan Richardson <jonathar@broadcom.com>,
	Scott Branden <scott.branden@broadcom.com>,
	Oza Pawandeep <oza@broadcom.com>
Subject: Re: [PATCH v1 1/3] dt-bindings: Document Broadcom OTP controller driver
Date: Sun, 30 Oct 2016 20:38:48 -0500	[thread overview]
Message-ID: <20161031013848.4vi2544tb5cs65nk@rob-hp-laptop> (raw)
In-Reply-To: <1477336324-10543-2-git-send-email-jonathan.richardson@broadcom.com>

On Mon, Oct 24, 2016 at 12:12:02PM -0700, Jonathan Richardson wrote:
> From: Jonathan Richardson <jonathar@broadcom.com>
> 
> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
> Tested-by: Jonathan Richardson <jonathan.richardson@broadcom.com>
> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
> Signed-off-by: Oza Pawandeep <oza@broadcom.com>
> Signed-off-by: Jonathan Richardson <jonathan.richardson@broadcom.com>
> ---
>  Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt b/Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt
> new file mode 100644
> index 0000000..6462e12
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt
> @@ -0,0 +1,17 @@
> +Broadcom OTP memory controller
> +
> +Required Properties:
> +- compatible: "brcm,ocotp" for the first generation Broadcom OTPC which is used
> +  in Cygnus and supports 32 bit read/write. Use "brcm,ocotp-v2" for the second
> +  generation Broadcom OTPC which is used in SoC's such as Stingray and supports
> +  64-bit read/write.

These should be SoC specific. While I'd guess this block is simple 
enough, having the SoC can define what all the bits are. Yes, there is a 
binding to define those, but you may not use that.


> +- reg: Base address of the OTP controller.
> +- brcm,ocotp-size: Amount of memory available, in 32 bit words
> +
> +Example:
> +
> +otp: otp@0301c800 {
> +	compatible = "brcm,ocotp";
> +	reg = <0x0301c800 0x2c>;
> +	brcm,ocotp-size = <2048>;
> +};
> -- 
> 1.9.1
> 

  reply	other threads:[~2016-10-31  1:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-24 19:12 [PATCH v1 0/3] Add support for Broadcom OTP controller Jonathan Richardson
2016-10-24 19:12 ` [PATCH v1 1/3] dt-bindings: Document Broadcom OTP controller driver Jonathan Richardson
2016-10-31  1:38   ` Rob Herring [this message]
2016-10-31 20:12     ` Jonathan Richardson
2016-10-24 19:12 ` [PATCH v1 2/3] nvmem: Add the " Jonathan Richardson
2016-10-31 14:23   ` Srinivas Kandagatla
2016-10-31 19:55     ` Scott Branden
2016-10-31 20:38       ` Florian Fainelli
2016-10-24 19:12 ` [PATCH v1 3/3] ARM: dts: Add node for " Jonathan Richardson
2016-11-16 20:51   ` Florian Fainelli
2016-10-24 19:39 ` [PATCH v1 0/3] Add support for Broadcom OTP controller Linus Torvalds
2016-10-24 19:54   ` Florian Fainelli
2016-10-24 20:14     ` Linus Torvalds
2016-10-24 21:27       ` Florian Fainelli
2016-10-24 21:52         ` Linus Torvalds
2016-10-24 22:45           ` Markus Mayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161031013848.4vi2544tb5cs65nk@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathan.richardson@broadcom.com \
    --cc=jonathar@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=oza@broadcom.com \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=scott.branden@broadcom.com \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®