From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Hans de Goede <hdegoede@redhat.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] Input: gpio_keys_polled - keep button data constant
Date: Mon, 31 Oct 2016 12:41:25 +0200 [thread overview]
Message-ID: <20161031104125.GK23812@lahna.fi.intel.com> (raw)
In-Reply-To: <1477696485-6995-1-git-send-email-dmitry.torokhov@gmail.com>
On Fri, Oct 28, 2016 at 04:14:39PM -0700, Dmitry Torokhov wrote:
> diff --git a/include/linux/gpio_keys.h b/include/linux/gpio_keys.h
> index ee2d8c6..d1250ad 100644
> --- a/include/linux/gpio_keys.h
> +++ b/include/linux/gpio_keys.h
> @@ -2,7 +2,6 @@
> #define _GPIO_KEYS_H
>
> struct device;
> -struct gpio_desc;
>
> /**
> * struct gpio_keys_button - configuration parameters
> @@ -31,7 +30,6 @@ struct gpio_keys_button {
> bool can_disable;
> int value;
> unsigned int irq;
> - struct gpio_desc *gpiod;
Please remove the kernel-doc comment of this member as well.
> };
prev parent reply other threads:[~2016-10-31 10:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 23:14 Dmitry Torokhov
2016-10-28 23:14 ` [PATCH 2/6] Input: gpio_keys_polled - always use gpiod_get_value_cansleep Dmitry Torokhov
2016-10-28 23:14 ` [PATCH 3/6] Input: gpio_keys - annotate PM methods as __maybe_unused Dmitry Torokhov
2016-10-28 23:14 ` [PATCH 4/6] Input: gpio_keys - fix leaking DT node references Dmitry Torokhov
2016-10-28 23:14 ` [PATCH 5/6] Input: gpio_keys - add support for GPIO descriptors Dmitry Torokhov
2016-10-29 8:38 ` Linus Walleij
2016-10-28 23:14 ` [PATCH 6/6] Input: gpio_keys - switch to using generic device properties Dmitry Torokhov
2016-10-31 10:44 ` Mika Westerberg
2016-10-31 10:41 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161031104125.GK23812@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=hdegoede@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome