From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [ARM] Fix stack alignment when processing backtraces
Date: Mon, 31 Oct 2016 10:26:31 -0600 [thread overview]
Message-ID: <20161031162631.GB28817@obsidianresearch.com> (raw)
In-Reply-To: <20161031085126.GT1041@n2100.armlinux.org.uk>
On Mon, Oct 31, 2016 at 08:51:26AM +0000, Russell King - ARM Linux wrote:
> > -.Ldumpstm: stmfd sp!, {instr, reg, stack, r7, lr}
> > + /* Must maintain 8 byte stack alignment */
> > +.Ldumpstm: stmfd sp!, {r3, instr, reg, stack, r7, lr}
> > mov stack, r0
> > mov instr, r1
> > mov reg, #10
> > @@ -140,7 +141,7 @@ ENDPROC(c_backtrace)
> > teq r7, #0
> > adrne r0, .Lcr
> > blne printk
> > - ldmfd sp!, {instr, reg, stack, r7, pc}
> > + ldmfd sp!, {r3, instr, reg, stack, r7, pc}
>
> I'd prefer r8 to get used rather than r3, as it makes it look like
> r3 is somehow required to be preserved when that's not the case.
> Makes the code slightly more difficult to understand.
Sure, I will change that and send it to your tracker.
Thanks,
Jason
prev parent reply other threads:[~2016-10-31 16:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 17:05 Jason Gunthorpe
2016-10-28 17:57 ` Jason Gunthorpe
2016-10-31 8:51 ` Russell King - ARM Linux
2016-10-31 16:26 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161031162631.GB28817@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome