From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S945943AbcJaTaZ (ORCPT ); Mon, 31 Oct 2016 15:30:25 -0400 Received: from mail-bn3nam01on0075.outbound.protection.outlook.com ([104.47.33.75]:31872 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S945905AbcJaTaW (ORCPT ); Mon, 31 Oct 2016 15:30:22 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yazen.Ghannam@amd.com; Date: Mon, 31 Oct 2016 15:15:44 -0400 From: Yazen Ghannam To: Borislav Petkov CC: , , Subject: Re: [PATCH v2 1/2] x86/AMD: Fix cpu_llc_id for AMD Fam17h systems Message-ID: <20161031191544.GA5862@yaz-fedora.dyhomenet> References: <1477669918-56261-1-git-send-email-Yazen.Ghannam@amd.com> <20161028165740.eizolvqnq5xh3azh@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20161028165740.eizolvqnq5xh3azh@pd.tnic> User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [73.35.89.163] X-ClientProxiedBy: CY1PR14CA0024.namprd14.prod.outlook.com (10.163.13.162) To MWHPR12MB1391.namprd12.prod.outlook.com (10.169.206.14) X-MS-Office365-Filtering-Correlation-Id: 520ab65e-9d7d-422d-3db2-08d401c253ec X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1391;2:mTTHJc009W5T/ToZvqCZJFp6DaNq/X3fO1jFRkx8aaOEOAXzX/xv/KR6dFJL3iUtuUDvCwhwi+Gsfk7wOrby6NMz/JD5uNXD/YVVkA560HRHR+aLEPHqOCugCB4I8CVQ7K1CnhqVsma4HgSxeYwlqSiLEx6iytDTNl7KDhJNwSK+fE+8eGJzaGJY8hsNhpHj13koYy0mxqZQFhUJUG3BVA==;3:pf0s+QBQXXi2ofcDMKH73Zaow6+TWbz0yy8xkjRQeWV/bc1e/a1JjX4RSd6BsLDv7o0nQNJCjoSOcasnFo0dRN1CUwgk8EpoahjLWfMODyTyzPZEVRQ6EqX67/N0LJTSi9b9UhiqBlQ3iDcO1ViLwA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:MWHPR12MB1391; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1391;25:bV03H8kKf8i4bdvwlXIfXgirL8uLoei9esndRE5BMvGPSNORd+m/gAMavOkNWqe3d5DUIq94cAoQ6Qwb2fzcGu+xM6Nrmbi9hwKqc3f9yY+b9Rkq92rKFvcguYTB002EJiD8i2qTDAzcqdvSroMXH2iB2XzfmvgXXHQENHp1c3PwMBdMC3pg8+iKOIzF4V4GHbojOPbzZTpszz+r+uIk7NTlWJNJUOIGo30WVgNi1V7sDocYlT5bPvQZW4nO8sCuMzepVOe8BRKZw1CMPC7SsqQIrQ4CNbtdAZgUwyiuoxqMxLTwhbth7YjnFZC/IMYJskXgYHUdHNiwCJ4j6JmxLY5YucXH8D6mWYs06VInIRxZryZKBM9DfZb/V3uWwRL90egrBXLaCh8ZsOsEtAbHjja49PC0tZVMSQoS7yhruXqnKEzDEWntsPZUuP/fxiDjj5eY+/34s0nt2FaVoIihODK56SWZI7ZQjaJJ880UpPG+68+922uoDDc2dCShQu4Fxkd3kQhZj1uCfkq1+toQnQ2vmbcO6vXv5yIEnspKhh9anTHS0QkGo5BlwnPD6jY7OS/W2HSmy8T5dsCrmsG5x3ZpGKaZ6/FekrJF883ddou5yMzwY3zbvj6kzoAVDRfQZsATItLOlAr05z1wcf2RVwtyT9GWcFnioBNvKexCJgfPoXUQZu5NVWLSHCAgLEr+qt2RSPBrdBUSIydYzOxYc8fjvjX7IoDn8rD4dczAfS4= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1391;31:GYwi2TVXmiDWTcXm02fxyVyuEycN1TXXDs4pO9YY6SpC0nPYqHvSZmidmQBvjsh+f0KUz8RKLZMK+MlImST5XSt3JSx7YmFy1gj4WV2HJYHExvhX3/vaik0fnPafiZ8oVchCZKVj90BL158REgH7Jhqs1XeL8/NNFl14+P+fIugsIerWhnIaKI3KWi20kUH7SnPXqLwoxoEZXqGJgtTv7zlVlKJnjyZuvCIWGzXGu8KEFP6bxFnwLgf6odVufxQJ;20:8ZCQK0u6tmbBn/99hUodEkm7DBp6qRqdchoKoQ4rVIS3yzPP5YsZ29rkg5zNDb2jtORe+PrRWTF8DVeTxXq3I+fAf9JHYOEa2qhHuOEnXBS3+26uY8N+wphbsSf7kJWZQ5ciIHvpKJJ9NmvXGwiFM8g01KAuOwPbhGRVPxzurQWkgp2jm5tbjf6YljkxQZuqjPLZCbNS8/NMNodunD42NVqFRt35fEpOB7/4fEYAi4wnwKoGaPjNxtj8+W2r1dcBG9OaQ6mAOUdHyJnUKuxf2QdyHNCdsPpwJEnlgi6/UsuMdqT4658E5xcJ3Sq+Lf6Qv5yNNHUTE2bielmqsv8OtPUNxPyZ0/dkF7BJgUztA5/XYC/Krux2c+5RczilEABBlc1GFyTOnkdA7m9eFdFZ2VDsyFiBdY+aHz03wR3aD8cnoAFmigNlF/nFbJsd/S30eSFL9YQ0hYFf2I9WkzZgKxjNCbx5M0CrsGecTmNKhFgE0ZYtoqaHX28a/L73e7FY X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:MWHPR12MB1391;BCL:0;PCL:0;RULEID:;SRVR:MWHPR12MB1391; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1391;4:9EGbHvw4EGOsgHdtYGg9AnBjYuv/KVp5lqlNN4Gpp4rx8yQrEfRBN6ewpid/GnlysOk3jO/ed4TEcJKvX2n0D809Y0CUZI2dO2pYM0kXpAODZgyoLZ1HfaVXTWuxQ3mq1dP8y1H8E6IFuyrDH0pK/wyypHg43SU2ocCmfGm1vttFUwq1J4lTeNh5tRfMMX2kwsMl97Wbl2QJJqNjjJs16+Y7Q/LYHJd+FeHEztxnyLMjDs7mU2K88I9TXRzZLZdc4Tix8hVgD1CiZIm2WML3yzx1cMF9yVVaewV6e4zsrmDM+lal0n5Ffd8fkxMJkuvsYwbaloL5Lxb25I0EyKjS8eaa4jsgh7MhcF+Zu0gyX+e2TT+7soMfC2IAhFXqONbWyEhUUADG4H7Gi0CKB58Q3OXsFeRc9dTeFdqV/lrN1ddgl07H/fEpReZY3cjpUAkaUY+M41jD2u1o8AhuBqZiQU1SUPkzS8hONCnYgUgSmv43KZOnZWQkX5tV+kNJS+qk X-Forefront-PRVS: 01128BA907 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(189002)(7736002)(76176999)(105586002)(1076002)(305945005)(7846002)(110136003)(8676002)(5660300001)(101416001)(586003)(86362001)(6916009)(4001350100001)(3846002)(2906002)(92566002)(6116002)(4326007)(6666003)(97756001)(23726003)(2950100002)(50466002)(81166006)(19580405001)(19580395003)(46406003)(83506001)(68736007)(77096005)(50986999)(54356999)(106356001)(189998001)(97736004)(9686002)(47776003)(81156014)(42186005)(33656002)(66066001)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR12MB1391;H:yaz-fedora.dyhomenet;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR12MB1391;23:E+kNvVsz3BClwm4/H3P4ZxIkiwkfQrcvK4zg8WGsJ?= =?us-ascii?Q?gnoTpQxUyJIdW6kqdrlXa6b1T9x5bDk4iej3tMDU6TxN6dYXmPLinGeBEHBY?= =?us-ascii?Q?M008eCh7pLOG1+VpNw+xQz/4cKwHqqbZ+y1gkiI3p9SnUxBuJrtsQvf50fId?= =?us-ascii?Q?gJ3fKGdOed8TVl1ElovYychl+WqyRgZ6vkjiOUrjAdN0DWV7smW3Tp3m5a5O?= =?us-ascii?Q?sCxQ/QybCp0oePBXVWRmTKyVZcRgVvh/d0HZdYYaTJr0uy5SiEu9q66QOkns?= =?us-ascii?Q?CLadXJqjXIGJQsq1+sDupFH5/ggB1Yfi0Z6HvQp0jDuYs2ccSzK4MdTpXgJe?= =?us-ascii?Q?kZqmCJIPk5BBOHkNGPcpRbk35KOLc9Bq5PNlZpe83YiG4ewKPfRBCjQSOYOs?= =?us-ascii?Q?LqeyA3R4otukTHe6d5VM9k5uGEV6imbqwZjQHQp+68yiQUeqTEBKT+xABboP?= =?us-ascii?Q?hITVAAe/x8EdkjRwowKzUash09NJKYrkxrhnFvqPa9HMKPPVsVme8OH2TArc?= =?us-ascii?Q?icuvqJkXhbmjpXoGsu/vhQL+PB7jQnHVwFCL076dTlKxKxJBXUv1TYMgpSxH?= =?us-ascii?Q?vSZFj7//krEKL7MnvfDQY+VxOLS9BOYVAnZ7Zaw8yJpoHf2HdHVbp6Nv7HCK?= =?us-ascii?Q?zw4X/U4TYagBB4t4hafeGzVCiIDen5HebOzrVhRRVIjH9/wlWqnb1Lh2zfsS?= =?us-ascii?Q?1VRnvjW5wGsB6ADoSsPB+EJBE9skSjnrv+EXJj1T8PhMlCRVpOoby2FKNSm0?= =?us-ascii?Q?rbisLJadyONTyoPZJOHVGzB7bDjwjMI+Zlo6/H8pBy310In8ObKs5Is4amou?= =?us-ascii?Q?EJS1RZr7OGDUSwHOqpAMs7oRKcYJdCTwXwYQPoJNVbjKBEtGFZKK+FyYgKUT?= =?us-ascii?Q?epykTfb8/6wYP6zi7/0M1FGcQRWNqrJOhntwjkxuiygIV/seRKXoA0c9Rrec?= =?us-ascii?Q?q11EzM8Dh7Qex+lst0ZnhaAUeKo3QHqcUYCJtSLeCFd3RhbbL/wZqZOmQ/YI?= =?us-ascii?Q?jra2jUBHid64PV+XRG+KyOCb7UpeXeWt/bWB1L4/RVUGlKl9iDj1Use+z8nn?= =?us-ascii?Q?hi+dIH6eOJZPWXHN9byDrMamydf5I9AleFRybyT1Imj44SexPQzpTdBYPaNw?= =?us-ascii?Q?cxu8arDKAcbUObXEMm5yXXKuQG2kSnvQ0TlAZ+urjnz0OZmwtm26WnpJD+nr?= =?us-ascii?Q?ih6yq8UDDA+I54rFiznNJTk0itNphT87lhp?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1391;6:OWjVoKalzeiRng4HbMHyuXsFHbL2S9ZORKYxUxFx1dEzaHOGoXfMyLLiPuVCHWUnpD8xSvHMu7OeDd8ecHigL45/JcR3cQsXjKr7bbahlHkrPKRcskP+BcWkB1hjGYL+PkMQZusyXC4Tsx3mhZ/Gqon7epWvyJK0C5PBCWJCsgLAhqdUeQEFPfhF9Unao2DJo8jLG2qiv6J/dj/a8G4LpjAFGvrHFhHLbhUqNw8uvK4T6HwS1qib+K80Yyb8bfKAMYQke221FzV51NbglB4l/5X7SmzJFxfiTMbY68aXI6qUBTFBHXhgFrmWIkdoWVD39wFaq3CshIgV7N3SZ76mf6BNenFqUyvxmUE1y5Wr5SM=;5:7tFHnw9Zr16wEyG7eguUESK2c+77bNY9MvJaEBm8LvyCgfWelaovdAX2eQyeGDAV7JQWq6B66LYyHITJ6QEJy8LK4hPkREuPRXEc/9u5oK1o9G8IUEXVHQH8Iarvj6hDYEdk/BRW7VcCdMRh0w7hFg==;24:PjE0Nhxa2jChDm9d2223vP6Rw2i4ejquBUBDYta/lqCN4COxQt/uS82UQFyVdQcYJNQ1OH2R33rkHMtqsYMkBFOyzDbhVDEHzbLpvm7f1CY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1391;7:uYhpAwc83ku4EbIiyddOWWi5At1uM27HMCZer0sc9h9TJBilgCNdiEUb1LdwuiSSQ3/5kB3s/El63lKxcjfogGmRy+QdU+dBwdlHerIw/yMXIW4+DsctX3kverWOobYJ4MpSXctFstsc/EcAhSZcSQavLRBFiV7eY3GH8G1E7SzLkGgUazKibk1Ttn2iPj2zJ0qQr6m6AW+hyymGMSJudE0a/2/pfuXUkTd6m3b/mVr9LxSdtele63oC4fZOIQzQB0GGTScdQXTbG4S2zHGr1Zi+0Z2X5XT6vnyzvw3bSjEPpB0aeOvPtRcL85I01x0Fh9OeEcoUs+ejKnDpS/eink28p1Js1wDcAX4zvy+PG78=;20:P3k17j23qZFxClnFC+G1F58g90KsvVcNwhwNUMF/z/gCnEXN8zn+x49c5YG49VhWg/zOhpmXUaaI+wFq94TA5/+5qbcokh6CbAHXFEhNIP7ihH0PYxGMrAbzpURQ7W6kij2SD98ptpfkUqyb7nSvaQWoChRGvwmHjHvCpAMtwdfd4MHyg31jLFOHKRyr5N+1kcWLomQA1rbk5VOpT0SoDGKl5x9qxnV6pTsDCS3JOubidsREPkAqkCSWMYM1rV3T X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2016 19:15:50.3031 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1391 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > The current Fam17h cpu_llc_id derivation has an underflow bug when > ^ > (Last Level Cache ID) > > Let's write it out the first time. > Ack. > > > > The apicid decoding is fixed for bits 3 and above, > ^ > "is fixed ... in register... " > Ack. > > which give the core > > complex, node and socket IDs. The LLC is at the core complex level so we > > can find a unique cpu_llc_id by right shifting the apicid by 3. > > "... because then the LSBit will be the Core Complex ID." > Ack. > > We can fix the underflow bug and simplify the code by replacing the > > current cpu_llc_id derivation with a right shift. > > > > Signed-off-by: Yazen Ghannam > > Cc: # v4.4.. > > Fixes: 3849e91f571d ("x86/AMD: Fix last level cache topology for AMD Fam17h systems") > > --- > > I'll run it soon. > Thanks, Yazen