From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932342AbcKAToQ (ORCPT ); Tue, 1 Nov 2016 15:44:16 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33725 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932170AbcKATnq (ORCPT ); Tue, 1 Nov 2016 15:43:46 -0400 From: Lorenzo Stoakes To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Paolo Bonzini , Michal Hocko , Greg Kroah-Hartman , Lorenzo Stoakes Subject: [PATCH] platform: goldfish: pipe: use get_user_pages_unlocked() Date: Tue, 1 Nov 2016 19:43:43 +0000 Message-Id: <20161101194343.24072-1-lstoakes@gmail.com> X-Mailer: git-send-email 2.10.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Moving from get_user_pages() to get_user_pages_unlocked() simplifies the code and takes advantage of VM_FAULT_RETRY functionality when faulting in pages. Signed-off-by: Lorenzo Stoakes --- drivers/platform/goldfish/goldfish_pipe.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c index 1aba2c7..2b21033 100644 --- a/drivers/platform/goldfish/goldfish_pipe.c +++ b/drivers/platform/goldfish/goldfish_pipe.c @@ -308,10 +308,8 @@ static ssize_t goldfish_pipe_read_write(struct file *filp, char __user *buffer, * returns a small amount, then there's no need to pin that * much memory to the process. */ - down_read(¤t->mm->mmap_sem); - ret = get_user_pages(address, 1, is_write ? 0 : FOLL_WRITE, - &page, NULL); - up_read(¤t->mm->mmap_sem); + ret = get_user_pages_unlocked(address, 1, &page, + is_write ? 0 : FOLL_WRITE); if (ret < 0) break; -- 2.10.2