From: Borislav Petkov <bp@alien8.de>
To: Aaron Miller <aaronmiller@fb.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] EDAC: expose per-dimm error counts in sysfs
Date: Wed, 2 Nov 2016 11:54:12 +0100 [thread overview]
Message-ID: <20161102105412.cwywcucgwrvmniy5@pd.tnic> (raw)
In-Reply-To: <7EB49132-0CB0-46AE-8F2C-1AF334DE4494@fb.com>
On Fri, Oct 28, 2016 at 06:13:08PM +0000, Aaron Miller wrote:
Please do not top-post.
...
> On Thu, Oct 27, 2016 at 02:33:32PM -0700, Aaron Miller wrote:
> > The old 'csrowX' sysfs directories had per-csrow error counters, but the
> > new 'dimmX' directories do not currently expose error counts.
> >
> > EDAC already keeps these counts, add them to sysfs so per-dimm counts
> > are still available when CONFIG_EDAC_LEGACY_SYSFS=n
> >
> > Signed-off-by: Aaron Miller <aaronmiller@fb.com>
> > ---
In any case, after looking at Mauro's docs changes:
https://lkml.kernel.org/r/cover.1477765574.git.mchehab@s-opensource.com
you'd need to add those new sysfs files to the "SYSFS INTERFACE" section
of wherever Documentation/edac.txt ends up. I believe it is:
Documentation/{edac.txt => admin-guide/ras.rst}
I believe the easiest would be if you redo this patch ontop of his
changes.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2016-11-02 10:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 23:25 [PATCH] " Aaron Miller
2016-10-27 18:07 ` Borislav Petkov
2016-10-27 18:18 ` Mauro Carvalho Chehab
2016-10-27 21:23 ` Aaron Miller
2016-10-28 9:55 ` Aaron Miller
2016-10-27 21:33 ` [PATCH v2] " Aaron Miller
2016-10-28 13:02 ` Borislav Petkov
2016-10-28 18:13 ` Aaron Miller
2016-11-02 10:54 ` Borislav Petkov [this message]
2016-11-03 22:01 ` [PATCH v3] " Aaron Miller
2016-11-04 11:21 ` Borislav Petkov
2017-01-19 8:56 ` Aaron Miller
2017-01-19 9:29 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102105412.cwywcucgwrvmniy5@pd.tnic \
--to=bp@alien8.de \
--cc=aaronmiller@fb.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®