From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756961AbcKBSz2 (ORCPT ); Wed, 2 Nov 2016 14:55:28 -0400 Received: from up.free-electrons.com ([163.172.77.33]:46682 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756911AbcKBSz1 (ORCPT ); Wed, 2 Nov 2016 14:55:27 -0400 Date: Wed, 2 Nov 2016 19:55:15 +0100 From: Maxime Ripard To: Chen-Yu Tsai Cc: dri-devel , linux-arm-kernel , linux-kernel , Daniel Vetter , David Airlie Subject: Re: [PATCH] drm/sun4i: Add a few formats Message-ID: <20161102185515.g42fjhoqxtlnqigc@lukather> References: <20161018084614.2443-1-maxime.ripard@free-electrons.com> <20161024144014.occkqw2v5c2ghx4w@lukather> <20161027143505.rblgbz5uqjynrtjk@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fnlbyqha5f7dsy7h" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fnlbyqha5f7dsy7h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 29, 2016 at 06:25:46PM +0800, Chen-Yu Tsai wrote: > On Thu, Oct 27, 2016 at 10:35 PM, Maxime Ripard > wrote: > > Hi, > > > > On Tue, Oct 25, 2016 at 08:42:26AM +0800, Chen-Yu Tsai wrote: > >> On Mon, Oct 24, 2016 at 10:40 PM, Maxime Ripard > >> wrote: > >> > Hi, > >> > > >> > On Fri, Oct 21, 2016 at 11:15:32AM +0800, Chen-Yu Tsai wrote: > >> >> On Tue, Oct 18, 2016 at 4:46 PM, Maxime Ripard > >> >> wrote: > >> >> > The planes can do more than what was previously exposed. Add supp= ort for > >> >> > them. > >> >> > > >> >> > Signed-off-by: Maxime Ripard > >> >> > --- > >> >> > drivers/gpu/drm/sun4i/sun4i_backend.c | 20 ++++++++++++++++++++ > >> >> > drivers/gpu/drm/sun4i/sun4i_layer.c | 6 ++++++ > >> >> > 2 files changed, 26 insertions(+) > >> >> > > >> >> > diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/= drm/sun4i/sun4i_backend.c > >> >> > index afb7ddf660ef..b184a476a480 100644 > >> >> > --- a/drivers/gpu/drm/sun4i/sun4i_backend.c > >> >> > +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c > >> >> > @@ -96,6 +96,22 @@ static int sun4i_backend_drm_format_to_layer(s= truct drm_plane *plane, > >> >> > *mode =3D SUN4I_BACKEND_LAY_FBFMT_ARGB8888; > >> >> > break; > >> >> > > >> >> > + case DRM_FORMAT_ARGB4444: > >> >> > + *mode =3D SUN4I_BACKEND_LAY_FBFMT_ARGB4444; > >> >> > + break; > >> >> > + > >> >> > + case DRM_FORMAT_ARGB1555: > >> >> > + *mode =3D SUN4I_BACKEND_LAY_FBFMT_ARGB1555; > >> >> > + break; > >> >> > + > >> >> > + case DRM_FORMAT_RGBA5551: > >> >> > + *mode =3D SUN4I_BACKEND_LAY_FBFMT_RGBA5551; > >> >> > + break; > >> >> > + > >> >> > + case DRM_FORMAT_RGBA4444: > >> >> > + *mode =3D SUN4I_BACKEND_LAY_FBFMT_RGBA4444; > >> >> > >> >> The A20 manual only lists ARGB4444, not RGBA4444. There might be > >> >> some discrepancy here. We can deal with them > >> > > >> > Hmm, yes, that's weird. But I guess this would be part of porting it > >> > to the A20. > >> > > >> >> Also there are some more formats missing from the list, could you > >> >> add them as well? > >> > > >> > Which one do you refer to? > >> > >> RGB556 and RGB655. > > > > These formats are not supported by Linux yet though. >=20 > I see. Sorry for the noise. >=20 > Acked-by: Chen-Yu Tsai Applied with a more verbose commit log. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --fnlbyqha5f7dsy7h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYGjaOAAoJEBx+YmzsjxAgTzkQAK0NYr/nVDwgy0jkHOdgqMBn nExqnOxynzhn8kEhkN08LKsBrRBLvgzuDz7IA8X6ofzLP2Xdie7WuBYMEoagNL7Y FZXPgt1Rz5WwMcrJV1+u5AufiJqEfNSFra3/BoxyHgtJtRqtLGwIuLF+sdP1MeJs WTIlxPi7OEke0YYL0KAbsCLDqzASQNoVAewnVCAxly2EXub626YKpoLOdZoJQIC6 h3vpCuzyNZzx5iq1Upqx1F2ADtkeeGzf+llrQvoTJCvsxfsn3H+LSv7EGiL74fEk 8vraECBz1NZIzxoJeAuD8/JLEUyaDTIi60cyJ2ZKVTX6qdH27sVOiPlFk7NvWH0Q itbCBxQ4Qb+zAnSTmzwbKEjhYewkR1kMp9sZzSNWCHpvfxOIw34RrF8ZsbG9vcFU I8reHR7Co3zmpEmfudJkZrukmNZVtxb7GRyZ9hL/Vpw50xuAiqh6aNrH/bNvkI9k ngWdxql/W1FsoBEfrOw6E0JzB2bm6p47KUW7JgqIkm71Der7um/ZImvybNk814lz z5n8+sbebwZKCCSSh8CzJl1Z6X7UcrZiR3kvMX3IKlqI8gK+IfX3Vvb10Sbzc1ew htjU78KnMNvgK8ncy+ZAmEHsQi3v/BO/pqkHyeL5Sm7oasqB2S3NF4XsAbQSaRD2 yishHH1FPHYZkw/rXmcy =mVsG -----END PGP SIGNATURE----- --fnlbyqha5f7dsy7h--