From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753947AbcKDTjG (ORCPT ); Fri, 4 Nov 2016 15:39:06 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52816 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750903AbcKDTjF (ORCPT ); Fri, 4 Nov 2016 15:39:05 -0400 Date: Fri, 4 Nov 2016 12:39:03 -0700 From: Andrew Morton To: Hans de Goede Cc: Linus Torvalds , Paul Burton , Rob Herring , Frank Rowand , Thorsten Leemhuis , Greg Kroah-Hartman , Tejun Heo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "console: don't prefer first registered if DT specifies stdout-path" Message-Id: <20161104123903.0693053785eb32f63822ac33@linux-foundation.org> In-Reply-To: <20161104121135.4780-2-hdegoede@redhat.com> References: <20161104121135.4780-1-hdegoede@redhat.com> <20161104121135.4780-2-hdegoede@redhat.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Nov 2016 13:11:35 +0100 Hans de Goede wrote: > This reverts commit 05fd007e4629 ("console: don't prefer first registered > if DT specifies stdout-path"). > > The reverted commit changes existing behavior on which many ARM boards > rely. Many ARM small-board-computers, like e.g. the Raspberry Pi have > both a video output and a serial console. Depending on whether the user > is using the device as a more regular computer; or as a headless device > we need to have the console on either one or the other. > > Many users rely on the kernel behavior of the console being present on > both outputs, before the reverted commit the console setup with no > console= kernel arguments on an ARM board which sets stdout-path in dt > would look like this: > > [root@localhost ~]# cat /proc/consoles > ttyS0 -W- (EC p a) 4:64 > tty0 -WU (E p ) 4:1 > > Where as after the reverted commit, it looks like this: > > [root@localhost ~]# cat /proc/consoles > ttyS0 -W- (EC p a) 4:64 > > This commit reverts commit 05fd007e4629 ("console: don't prefer first > registered if DT specifies stdout-path") restoring the original behavior. > > Signed-off-by: Hans de Goede I've added cc:stable@vger.kernel.org to my copy of this.