From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762138AbcKDWa6 (ORCPT ); Fri, 4 Nov 2016 18:30:58 -0400 Received: from up.free-electrons.com ([163.172.77.33]:45751 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751229AbcKDWa4 (ORCPT ); Fri, 4 Nov 2016 18:30:56 -0400 Date: Fri, 4 Nov 2016 23:30:53 +0100 From: Alexandre Belloni To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Alessandro Zummo , "David S. Miller" , rtc-linux@googlegroups.com, sparclinux@vger.kernel.org Subject: Re: [PATCH 0/3] rtc: remove modular usage from non-modular code Message-ID: <20161104223053.luroc2zcwfmppejo@piout.net> References: <20161031185527.20279-1-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161031185527.20279-1-paul.gortmaker@windriver.com> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/10/2016 at 14:55:24 -0400, Paul Gortmaker wrote : > My ongoing audit looking for non-modular code that needlessly uses > modular macros (vs. built-in equivalents) and/or has dead code > relating to module unloading that can never be executed led to the > creation of these rtc related commits. > > For anyone new to the underlying goal of this cleanup, we are trying to > not use module support for code that can never be built as a module since: > > (1) it is easy to accidentally write unused module_exit and remove code > (2) it can be misleading when reading the source, thinking it can be > modular when the Makefile and/or Kconfig prohibit it > (3) it requires the include of the module.h header file which in turn > includes nearly everything else, thus adding to CPP overhead. > (4) it gets copied/replicated into other code and spreads like weeds. > > Build tested on current linux-next (sparc32) to ensure no silly typos > or implicit include issues that would break compilation crept in. > > --- > > Cc: Alessandro Zummo > Cc: Alexandre Belloni > Cc: "David S. Miller" > Cc: rtc-linux@googlegroups.com > Cc: sparclinux@vger.kernel.org > > Paul Gortmaker (3): > rtc: make rtc-lib explicitly non-modular > rtc: sparc: make starfire explicitly non-modular > rtc: sparc: make sun4v explicitly non-modular > > drivers/rtc/rtc-lib.c | 4 +--- > drivers/rtc/rtc-starfire.c | 10 ++++------ > drivers/rtc/rtc-sun4v.c | 10 ++++------ > 3 files changed, 9 insertions(+), 15 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com