From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751633AbcKECfp (ORCPT ); Fri, 4 Nov 2016 22:35:45 -0400 Received: from up.free-electrons.com ([163.172.77.33]:47005 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750780AbcKECfo (ORCPT ); Fri, 4 Nov 2016 22:35:44 -0400 Date: Sat, 5 Nov 2016 03:35:41 +0100 From: Alexandre Belloni To: Keerthy Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, lokeshvutla@ti.com, t-kristo@ti.com Subject: Re: [PATCH 1/2] rtc: omap: Fix selecting external osc Message-ID: <20161105023541.udo27ehloo22mtlq@piout.net> References: <1477547846-5335-1-git-send-email-j-keerthy@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477547846-5335-1-git-send-email-j-keerthy@ti.com> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/10/2016 at 11:27:25 +0530, Keerthy wrote : > From: Lokesh Vutla > > RTC can be clocked from an external 32KHz oscillator, or from the > Peripheral PLL. The RTC has an internal oscillator buffer to support > direct operation with a crystal. > > ---------------------------------------- > | Device --------- | > | | | | > | | RTCSS | | > | --------- | | | > OSC |<------| RTC | | | | > |------>| OSC |--- | | | > | -------- | | | | > | ----|clk | | > | -------- | | | | > | | PRCM |--- | | | > | -------- -------- | > ---------------------------------------- > > The RTC functional clock is sourced by default from the clock derived > from the Peripheral PLL. In order to select source as external osc clk > the following changes needs to be done: > - Enable the RTC OSC (RTC_OSC_REG[4]OSC32K_GZ = 0) > - Enable the clock mux(RTC_OSC_REG[6]K32CLK_EN = 1) > - Select the external clock source (RTC_OSC_REG[3]32KCLK_SEL = 1) > > Fixes: 399cf0f63f6f2 ("rtc: omap: Add external clock enabling support") > Signed-off-by: Keerthy > Signed-off-by: Lokesh Vutla > Signed-off-by: Dave Gerlach > --- > > Boot tested and checked for rtc ticking on am335x-boneblack, am335x-bone > am437x-gp-evm, dra7-evm, dra72-evm. > > drivers/rtc/rtc-omap.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > Both applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com