From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Darren Hart <dvhart@infradead.org>
Cc: Lyude <lyude@redhat.com>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet Mode
Date: Sat, 5 Nov 2016 16:49:27 -0200 [thread overview]
Message-ID: <20161105184927.GE17290@khazad-dum.debian.net> (raw)
In-Reply-To: <20161105184522.GD100528@f23x64.localdomain>
On Sat, 05 Nov 2016, Darren Hart wrote:
> On Thu, Oct 27, 2016 at 03:46:44PM -0400, Lyude wrote:
> > For whatever reason, the X1 Yoga doesn't support the normal method of
> > querying for tablet mode. Instead of providing the MHKG method under the
> > hotkey handle, we're instead given the CMMD method under the EC handle.
> > Values on this handle are either 0x1, laptop mode, or 0x6, tablet mode.
> >
> > Changes since v1:
> > - Clarify kernel output when finding the tablet mode switch
>
> These two lines go below the --- below (they aren't meant to be part of the
> permanent commit message). Please see Documentation/SubmittingPatches.
>
> I've queued this to testing as it addresses Henrique's change request. Henrique,
> I'll add your Reviewed-by if you send it along, or drop it if you have more
> reservations.
No reservations, since it was tested to not regress previous thinkpads.
--
Henrique Holschuh
next prev parent reply other threads:[~2016-11-05 18:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 22:12 [PATCH] " Lyude
2016-10-27 14:52 ` Lyude Paul
2016-10-27 17:54 ` Henrique de Moraes Holschuh
2016-10-27 19:46 ` [PATCH v2] " Lyude
2016-11-05 18:45 ` Darren Hart
2016-11-05 18:49 ` Henrique de Moraes Holschuh [this message]
2016-11-05 18:55 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161105184927.GE17290@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=dvhart@infradead.org \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome