From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752040AbcKFMoK (ORCPT ); Sun, 6 Nov 2016 07:44:10 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33369 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751762AbcKFMoJ (ORCPT ); Sun, 6 Nov 2016 07:44:09 -0500 From: Naeil ZOUEIDI To: gregkh@linuxfoundation.org, bankarsandhya512@gmail.com, isdn@linux-pingi.de, sudipm.mukherjee@gmail.com, arnd@arndb.de, ansonjacob.aj@gmail.com Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Naeil ZOUEIDI Subject: [PATCH] This is a patch to the capi.c file that fixes one instance of the following error: ERROR: do not use assignment in if condition Date: Sun, 6 Nov 2016 09:55:15 +0100 Message-Id: <20161106085515.24141-1-naeilzoueidi@ubuntu.com> X-Mailer: git-send-email 2.10.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Staging: i4l: act200: Signed-off-by: Naeil Zoueidi --- drivers/staging/i4l/act2000/capi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/i4l/act2000/capi.c b/drivers/staging/i4l/act2000/capi.c index 62f5629..b494917 100644 --- a/drivers/staging/i4l/act2000/capi.c +++ b/drivers/staging/i4l/act2000/capi.c @@ -564,7 +564,8 @@ actcapi_data_b3_ind(act2000_card *card, struct sk_buff *skb) { blocknr = msg->msg.data_b3_ind.blocknr; skb_pull(skb, 19); card->interface.rcvcallb_skb(card->myid, chan, skb); - if (!(skb = alloc_skb(11, GFP_ATOMIC))) { + skb = alloc_skb(11, GFP_ATOMIC; + if (!skb) { printk(KERN_WARNING "actcapi: alloc_skb failed\n"); return 1; } -- 2.10.1