From: Shuah Khan <shuahkh@osg.samsung.com>
To: mchehab@kernel.org, wsa-dev@sang-engineering.com,
gregkh@linuxfoundation.org, keescook@chromium.org,
akpm@linux-foundation.org, sean@mess.org,
patrick.boettcher@posteo.de
Cc: Shuah Khan <shuahkh@osg.samsung.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] media: fix uninitialized variable warning in dib0700_rc_urb_completion()
Date: Mon, 7 Nov 2016 08:41:12 -0700 [thread overview]
Message-ID: <20161107154114.26803-2-shuahkh@osg.samsung.com> (raw)
In-Reply-To: <20161107154114.26803-1-shuahkh@osg.samsung.com>
Fix the following uninitialized variable compiler warning:
drivers/media/usb/dvb-usb/dib0700_core.c: In function ‘dib0700_rc_urb_completion’:
drivers/media/usb/dvb-usb/dib0700_core.c:763:2: warning: ‘protocol’ may be used uninitialized in this function [-Wmaybe-uninitialized]
rc_keydown(d->rc_dev, protocol, keycode, toggle);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
drivers/media/usb/dvb-usb/dib0700_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/dvb-usb/dib0700_core.c b/drivers/media/usb/dvb-usb/dib0700_core.c
index f319665..cfe28ec 100644
--- a/drivers/media/usb/dvb-usb/dib0700_core.c
+++ b/drivers/media/usb/dvb-usb/dib0700_core.c
@@ -676,7 +676,7 @@ static void dib0700_rc_urb_completion(struct urb *purb)
{
struct dvb_usb_device *d = purb->context;
struct dib0700_rc_response *poll_reply;
- enum rc_type protocol;
+ enum rc_type protocol = RC_TYPE_UNKNOWN;
u32 uninitialized_var(keycode);
u8 toggle;
--
2.9.3
next prev parent reply other threads:[~2016-11-07 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 15:41 [PATCH] media: Fix get_key_haup_common.isra.4() debug message to print ptoggle value Shuah Khan
2016-11-07 15:41 ` Shuah Khan [this message]
2016-11-08 11:23 ` [PATCH] media: fix uninitialized variable warning in dib0700_rc_urb_completion() Sean Young
2016-11-07 15:41 ` [PATCH] net/netfiliter: Fix used uninitialized warn in ip_vs_proc_sync_conn() Shuah Khan
2016-11-07 15:44 ` Anna Schumaker
2016-11-07 16:14 ` Shuah Khan
2016-11-07 15:41 ` [PATCH] net/netfilter: Fix use uninitialized warn in nft_range_eval() Shuah Khan
2016-11-08 23:13 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161107154114.26803-2-shuahkh@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=patrick.boettcher@posteo.de \
--cc=sean@mess.org \
--cc=wsa-dev@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®