From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752561AbcKHNcu (ORCPT ); Tue, 8 Nov 2016 08:32:50 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:53671 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752105AbcKHNco (ORCPT ); Tue, 8 Nov 2016 08:32:44 -0500 From: Arnd Bergmann To: "David S. Miller" , Philippe Reynes Cc: Arnd Bergmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: mii: report 0 for unknown lp_advertising Date: Tue, 8 Nov 2016 14:31:38 +0100 Message-Id: <20161108133232.1571441-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:miPmT4Q/aQ8+mRy71npHccSPlkgx8pcMr66rbofcdod47meVSZZ Fjmto47mPyljbcVLaoUyMwtxPrzONHhmSgBgm855OW8uK99FUveXHzQgi6Dl/3LLU7DouO5 Pd9HkatkHPEfJTn7E5ELplPgM8LtqjCL6tRY63+SnbTpt119faI1Z6dv4jXCF0D+z8s/pSV /yYRR/TeLScOQtpzPhvMw== X-UI-Out-Filterresults: notjunk:1;V01:K0:5r011Qsod+Y=:FE0i5TdnahY/s0jRBXOpgS xJPWYCRTFud9Xz4Hz8m0Zqy7K6YejuVt8S8WPax7bfhKJbc8+IRRowY2p5FG1CXboqqztmpnP aWOW9LiUcl4E4fiSCMHSMcuSP0KZw7A2ZYv+h4i2nCabtwV1BjjFBPhDzwv+L+Us6IcU+NMB8 EWucVW93VZAQCsojoLHl1XPDayHcwE45edA6kwnVYM7+XPGUmYDbbsoMPRaSPM4ic4XK+f81W KII6fDfw80g3DxQnFYoCXZRQQWXQOeoq5PDKgv2QN+EUsAyn5jQHfm9yVICbr16CiOKi05fg9 5r2BHAAFzw57MSsBVC09VvR6YoQfkZrhIEjHAlCZnPd/e2OtIjfZQqSgN/uhYzv2QP+PP5kVp 2Pw+aFblzToyet1QiP6fapzohx/VePbNo3DCCqHZKIY54VbYdotDmrMfKj/7ydLZwIDFSWBIW l5hC37VXN8mBP1JjQBWTvklu30XiTh4Awji58g0n/fUN5X6FeKrQlWm+ztgtE7/s8ymsH2XYi CC6LakMgqvO+PNNls8PlVJkZHJoyOWy9I8rBIXNdc2Jse0k30XDLVNExilJ/iZH6115ouHyhM v/mX9eVyCbNW0jxg1As7BeoO2UITaq2/Kd0AbzScSoGVqvfsU0dkWQ9RfDXgTdT9qqPE92fXB KWm+folxYN0mGjxdb/YEE4fz/ngR0hxRxNvS1rZPHlsLOj7HsKrUuH+d3fG0UPFMs3Ao= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The newly introduced mii_ethtool_get_link_ksettings function sets lp_advertising to an uninitialized value when BMCR_ANENABLE is not set: drivers/net/mii.c: In function 'mii_ethtool_get_link_ksettings': drivers/net/mii.c:224:2: error: 'lp_advertising' may be used uninitialized in this function [-Werror=maybe-uninitialized] As documented in include/uapi/linux/ethtool.h, the value is expected to be zero when we don't know it, so let's initialize it to that. Fixes: bc8ee596afe8 ("net: mii: add generic function to support ksetting support") Signed-off-by: Arnd Bergmann --- drivers/net/mii.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mii.c b/drivers/net/mii.c index 0443546fc427..6d953c53eed6 100644 --- a/drivers/net/mii.c +++ b/drivers/net/mii.c @@ -213,6 +213,8 @@ int mii_ethtool_get_link_ksettings(struct mii_if_info *mii, SPEED_100 : SPEED_10)); cmd->base.duplex = (bmcr & BMCR_FULLDPLX) ? DUPLEX_FULL : DUPLEX_HALF; + + lp_advertising = 0; } mii->full_duplex = cmd->base.duplex; -- 2.9.0