From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933797AbcKHVI1 (ORCPT ); Tue, 8 Nov 2016 16:08:27 -0500 Received: from mail.skyhub.de ([78.46.96.112]:37849 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932892AbcKHVIX (ORCPT ); Tue, 8 Nov 2016 16:08:23 -0500 Date: Tue, 8 Nov 2016 22:08:20 +0100 From: Borislav Petkov To: Thomas Gleixner Cc: "Luck, Tony" , linux-edac , X86 ML , LKML Subject: Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP Message-ID: <20161108210819.gx7bfw7pfx4e6tf4@pd.tnic> References: <20161101120911.13163-1-bp@alien8.de> <20161105131104.drouavgezizz4w7v@pd.tnic> <3908561D78D1C84285E8C5FCA982C28F3A22720B@ORSMSX114.amr.corp.intel.com> <20161107180853.4uxlvtoychzhwr2q@pd.tnic> <3908561D78D1C84285E8C5FCA982C28F3A22728C@ORSMSX114.amr.corp.intel.com> <20161108180932.wvvcbbzrzrai26eg@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 08, 2016 at 09:39:02PM +0100, Thomas Gleixner wrote: > That does not make any sense. Where is m.tsc initialized? I couldn't find > any place which does, except this and the conditional clear farther down in > that function. mce_gather_info->mce_setup does m->tsc = rdtsc(); And we do that *everytime* but then we go and clear the damn thing. I know, I know, I wanted to flip that logic too and read the TSC *only* when we want a precise timestamp but that would require more changes as mce_setup() is used at a bunch of places. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.