From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755114AbcKJB10 (ORCPT ); Wed, 9 Nov 2016 20:27:26 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:46702 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752532AbcKJB1Z (ORCPT ); Wed, 9 Nov 2016 20:27:25 -0500 Date: Wed, 09 Nov 2016 20:27:22 -0500 (EST) Message-Id: <20161109.202722.2270232582216800896.davem@davemloft.net> To: arnd@arndb.de Cc: tremyfr@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: mii: report 0 for unknown lp_advertising From: David Miller In-Reply-To: <20161108133232.1571441-1-arnd@arndb.de> References: <20161108133232.1571441-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 09 Nov 2016 16:27:53 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Tue, 8 Nov 2016 14:31:38 +0100 > The newly introduced mii_ethtool_get_link_ksettings function sets > lp_advertising to an uninitialized value when BMCR_ANENABLE is not > set: > > drivers/net/mii.c: In function 'mii_ethtool_get_link_ksettings': > drivers/net/mii.c:224:2: error: 'lp_advertising' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > As documented in include/uapi/linux/ethtool.h, the value is > expected to be zero when we don't know it, so let's initialize > it to that. > > Fixes: bc8ee596afe8 ("net: mii: add generic function to support ksetting support") > Signed-off-by: Arnd Bergmann Applied.