From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751948AbcKICQb (ORCPT ); Tue, 8 Nov 2016 21:16:31 -0500 Received: from mail-db5eur01on0056.outbound.protection.outlook.com ([104.47.2.56]:8670 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750927AbcKICQ3 (ORCPT ); Tue, 8 Nov 2016 21:16:29 -0500 Authentication-Results: spf=pass (sender IP is 217.140.96.140) smtp.mailfrom=arm.com; lists.infradead.org; dkim=none (message not signed) header.d=none;lists.infradead.org; dmarc=bestguesspass action=none header.from=arm.com; X-IncomingTopHeaderMarker: OriginalChecksum:;UpperCasedChecksum:;SizeAsReceived:1036;Count:14 Date: Wed, 9 Nov 2016 09:42:36 +0800 From: Huang Shijie To: Will Deacon CC: Catalin Marinas , , , , , , , Subject: Re: [PATCH v2 0/2] arm64: fix the bugs found in the hugetlb test Message-ID: <20161109014234.GA20242@sha-win-210.asiapac.arm.com> References: <1478583879-14654-1-git-send-email-shijie.huang@arm.com> <20161108140909.GF29087@e104818-lin.cambridge.arm.com> <20161108163642.GE20591@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20161108163642.GE20591@arm.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-IncomingHeaderCount: 14 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:217.140.96.140;IPV:CAL;SCL:-1;CTRY:GB;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(189002)(24454002)(199003)(33656002)(626004)(106466001)(5660300001)(6636002)(77096005)(4001350100001)(50466002)(46406003)(83506001)(189998001)(92566002)(1076002)(7846002)(356003)(586003)(4326007)(2906002)(104016004)(87936001)(305945005)(23726003)(8676002)(8936002)(86362001)(47776003)(6666003)(2950100002)(7696004)(110136003)(26826002)(246002)(50986999)(76176999)(97756001)(54356999)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR08MB0567;H:nebula.arm.com;FPR:;SPF:Pass;PTR:fw-tnat.cambridge.arm.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;AM1FFO11FD027;1:ldhn4y798ZJvqMh0vNZjxokyW6y3XAIDrc8TcOBTHBWuKzL4G08B+9uT6wgP4ADwleINBKPj9lQnLjtBfJUuMMgO/ozEF/xJsRDvP1z9NplrA0Mylh/Dl3QV7ClCfQajT1Al7ct/CU7sOdYjPPIk08MNGMlEinrLeAA+yyWyqn3DL+D5lk7drsdSEwoHRazC1NtJRPVL86iUAKxtNQ3uOxRT8o9U/m6+7j6ektNzEBT+PkdgOsV3QqrD/Ufh08ziUflqh3L7jnWicni8C5xI7uZIGXdhNejbYCfk2qw15At2f0GeolxmvfibLwAa1ztZsEsT+iI+6SJu4dr7Hf//LAHOtzq+nkQrie3uLHXxxsw2Mx5FLT/InrCFgrOLugarC4rNIzhGylIh+4Byk+sPAPww00DYec2yoR84Q9KEAJSGbGlx0zC2jVtvOrZ1L59D0Y8Be5lLL9PjgVgULDyseH6/pb2tqehZUWuS1FB2znFAtPczzHDRd8fhYweC2g0VS1X3P3tIUSrAp0I1R+4pWdwUjCttkRqzkFiQ5pkjkPYwNoAywGoyI3xpwMVXQEEZwFT9WO5nokYPZD9S4kfZwXx7Eq9zpoPvX9DIP3Kn065mFc5xVkMDYcnfuFZ3oh0L X-MS-Office365-Filtering-Correlation-Id: 2b2fadde-2973-4a04-6a0d-08d40841b89a X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB0567;2:LaHDM4cbfc8oRxQSGLCJmqWZ8wnYwDA24qmllIdRtQNkwjGiwZi+09Ho9qGA9rCJwtIyMMln/NdbSdSaFSHeNmpGzzWPqGaG+Ib0VWCwxHD6qgPJ4iJMjo6MfzS7QHkt8gRDwYmccXBp5EE0wDe2T0iZtQqQFflFE2Ur5Fg9ttG8Oxy9dV9vaPC2ts/i1eFoqm6so9FimNCRumHzR5TTcQ==;3:KJst53Sbhxj73K+6hj/xP8vX1N7hZXOn2TVeL7kzrC8po7Zvy9FML98YyqGDOO4Z8KRbBpXgC2tYnzJfjAvPPpGl4j2vHJk5uJD9j6Z+5o9WnV2ZK9ME1WrCzegUMnyi5KxbW5CmIbP2XiNMxUUzJ01vi5e1pV2bqqiVfbsXN7RBOobXgLTDDt0+RVhdKl+7qYaHQjAtrm2jAzRmyHTMdnHXmaQ40oWaEVueiU80J8aNFFhy65KDVScJWK0eIK1MDO/CTr3nxffjfhvQI56CihgzGhJwSZ1EeFZeKEhf+/0= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:DB5PR08MB0567; X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB0567;25:oriilWMSAtCmburmksomSlWMtCV0B4IxazQLCSQoEwJ5jCZNHwfYzYOqXWSuVEliRkzjC5EX1hmZVlWiC+Fg9rKZfDOOGaWWfyeMWr7m5dm9HmUelfNW3gBLXK5LeXulvcBW+0UjW34VG1PutTdvF3ZtrOMQ5uD+1rXPsmwn9amMUr2LrCydLQ8Q+GiudR0EjuAY4driL5rY38UbrV2T2ZsJHs0bmuSS553AXADOMxyFUN9Nm7/7/eLUKSSukVa+dt2Ymt4gZQv6D3++1aP4lUFpBDT00h8lsqZfiObMla95kUduN9QDjjQhfh2I9c58zsFsvqjfhP1Z6RmvIEmSXjO1uLzpplEti1hxm3ynBeexGGbLmnsDnQjlzUE6k1SS/kg/AWLiNcIB1ALJ4QaEzB/Eu1PUYMxPJ7jtsLxz/s7cYldC3+kefxzYZceV/GWp0I7bKnnzGM+QIOfKyxR3cugBFt5scwyG1s18rb1ATO9f2IV6dMvIpJ52sTZgiZ3om9LqIE5iXH4e/Ll+E+386Uq23Nla1jOfS2vtQJXcYxOfnsc/ub10KHgGbfK/ujyMzq/wL7kBVtoFKy2UUKwVYzv6o+geDSwMmLgvklTvBTpiPH0Y9ilmDYKp2gJrOiqbdy2QUXC4Ugqj24VlOHWgifp1EZ1vOPCRx3Wz20gNmJLc7+1EeBLKVjS5+GBPsF9nEzkFVxJE2KjYzUqKGoqQhXx4llD1rGQ+wjDz9TUVPIbT8r1JO1SXRUNqN7QUXJVA X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB0567;31:JPbvo8+9CYUKaZ4uqH/QL3mbvcAmV1wvMibcBW4+gKupd/xO+r5aQQF/5wUZFQQWOf8eIXs+bjHErHwRlwYaUpFl059dLs6m7m2lgKxvJD7w8Ft6Q1MLoLuC0zOBf550Z/hvVdGyCbjBlgBwTmJ050Zjfq+dzWi6urr95Y44KBA04y6WiRMy5Lk9Q9dVTSwTcG3W3ohmEIdw4vNKV31iNkQHSNeC4uL5aweYhT7WqE1iw0fjI4lnioFyfS80zo7lzY8qCi7I2rdkZSL6GGV1Gw==;20:N5wm5f6A1zSQnlZag2kmkYf4pBuY7f1BQ0xzIZQrZKluzvENzSMddTTXJYRyOuodNIH0YmsCZbUkeKJaDDEcpJ5MsNBUR55YJVrCVG1Y4IPRGGiej7+oMxLhwcZyjZb4NIe6mkxe9G0ZbYC1vIhyNRk50XWcW/7uiAt92PY4I8rv+cfqIXO5H9/BhQvSrlQiNDy0FMDlDuEIn73mNJ4QHckC2vtMPh7tLT8ioTEgicIhwhJGm9OvbL1mL/m1aHmS NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(13020025)(8121501046)(5005006)(13013025)(13024025)(13023025)(3002001)(10201501046)(6055026);SRVR:DB5PR08MB0567;BCL:0;PCL:0;RULEID:;SRVR:DB5PR08MB0567; X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB0567;4:QogScsxOPOpeksw9ZVFM+NcbVgpmnQ+hNK10IuA/HUveHCic628IzYCFqftjeY9U8Px4RVpckvRZk0u/KohR20NuyHwndBJJagQyhgOWh8UlV1FBAf1DvzypNWWpwGjpvVBAiI5N88eguyfGYnk1W1iU+exSps0XdgYIoXS/I5jj8tDrvbaopQTChSFdWPVrv0KdPy2U55I3ZEk6Mjt8UbpppQIPm4dChrKScpn0yW7TMCum+k/4Tap84i9EQYF6Ku0JC1WPWUlWsbgXMfgyo3Q7vN2L88+wrcMo4UEopv3JByNFl5HkKmldMi4mPtzbnDgPl191lW5AEvWUCJwujRW0QZSa+ym8xAzeqwz9BNE695AcEYugVIVSnuPXHVcW4E7R5WrOLmW9mXwoVhjy++Z23emKMrjnpHWD8U2lTMgTtHOSB3Lc6pxR4tGlaOq29lguZ/u/0ZnQIyctSP7xZuAjS9E4BSbBYIcW+4UD9QSpi5DRKeE1rK8Q9ukdVVy2KEVS+esKkK1bfmQc4mzkncRNSa4Rnf8N6pewLIegEYk= X-Forefront-PRVS: 0121F24F22 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DB5PR08MB0567;23:qiz2ZeT7T+aTdES5fu3sTlAivIHE5FheAYzwnRkSW?= =?us-ascii?Q?Y5h5wEuc8P4tgoyJrVf4BNWh9l7D3pDIQ7XiUK6PINBFbS0bhaWs1R4ZRWyO?= =?us-ascii?Q?/7hWQ6MutuzKLoRcj/9Xph+3CnoxaXn2LD4/pQbwEy90h48qR7gcnaL6pAVE?= =?us-ascii?Q?bUZJIA1bd5ctJ3q5vi8122lRvJwt12tJpn6Eta4AGBOGRtQrpK6FoH46WPkY?= =?us-ascii?Q?FLzNAimhm4UcfYy5EtmAy4XihiX0VYmUF6kyQooJ86lxx1DZ1ybHAlj1Nzti?= =?us-ascii?Q?jpKQ83IfvMRNHxZGNfZgZ4c3JElrmkIzxplUeELLztUPjFZDTunC5GHaAayL?= =?us-ascii?Q?IZXgLG+3kPclEv7xRwSmY1OFDtrOZwT8GB5YKPLlCRhI40KGAtskXNfjrZxb?= =?us-ascii?Q?NUlu0P0YuJ/LUQedOduTl2ffXvhTmY68ox10KNSxmxoj48zrlGFejaX++L3O?= =?us-ascii?Q?HHyXA6ZOT0W+W0psZ1dYpq/3PgnQeSEbun4Lqo7aLwnhKfOT5mKAtn0Tj9yx?= =?us-ascii?Q?iUfcetQzywRbFXXg5fmkmXMlzEzEmhMjhM8kHvxLtpGl3eZzbVpmz1mGHpsy?= =?us-ascii?Q?SPGYC+90+YOIVU70lyIG6dp9K+R3f+mUT53HLLlahhufFUinhA1nOxpa8goI?= =?us-ascii?Q?LAXHkobIGVpVzqSSeA3Yjc6Aj2CJRoqHwporpjlyGvKlwIORB0DXqWw3YDJC?= =?us-ascii?Q?LnmWJa+pA+kigAPqI+ILkVVjADstBlvVJP9jTLMyWuozylfcKVx8eURD9K5m?= =?us-ascii?Q?onAPSEC6/fdY8AR3U1jO9SzxX1ftleZp16edOQgdTDv7dcp9Wh2RD3RBdQ0L?= =?us-ascii?Q?3YCbglnW7lmDqPn+XZj6Y9D43HAbsRlmRxxSo+wlRYn4zWdvyLr/X1AyEjLR?= =?us-ascii?Q?7klZmNqyjSdpRfNfEti+SX2zItyRrQ7ua/qsS5J+MvKl+iG9eVb78BwVe2YS?= =?us-ascii?Q?YvgUwHIG2T0iMa1c1hOAxykPK2qVfRmWkYAuBpvRrwibIKH03GXjkE053YAV?= =?us-ascii?Q?mtnpkgsz6vrs74tsWHpjwu6gHTV12/Ct0YCgKzODv0DX/EJJDugvUHHivGMO?= =?us-ascii?Q?zlsReisq+NXaUVM2xVZ7ufIDA8D?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB0567;6:k7aAkmNsyA8lciUpUpRTPsDYYylndW5Vu2GJwTvrqyPFA7LwQEHFyUrvCqvDsMUFIYfaFOf36K32+csnDTRg1u5byHOEJqlDxyi7IT+BrW+Th8NcYUryTaRg30eU5bbPio2LyaII/pItwzhEwS/+IElp6utxZAt3VnzCq01Et45c7TuC2D8RHQd0NIGvFw+HKFkxyW+8ie1DXvt7DptVAgWspOtk+dRy1U66eVq0HQqAMUEJo4670Dw7JSaCX6ra0hpkgfnMfU5acEj3wV1k4e073xdJEo/d27iD4/5DQKbJD05CMznuTaCM05KVZsjt/HCuolapbZ4861eVEx3utkqhrBlOKtqmfRSGbN35HoQ=;5:XrKelT6IZNY4MniRG/2GcLCSoKr5JQiLfJWz+aRvxaYlKefq90Qbe2NJUVUHJAmzZBJplkVSrMI4Wu5ONh6PGUvlREClrC5W9UVs386RNRuya/sT2pf68RuTjXW3aNCL+jQh0tIz5XFWHqUMrZvUFR31RXivIIb+t1YhLry0SR0=;24:xb96XGlH1PHHlf8+8nCe1iKmuJZ6+oEycSEFJcvsPlZAZMiwLoHdmKpp4SegWxVOLH3+iw71HkQPRRrE3dWwoWGC+2nmQ6FACbJcR9bSdvI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB0567;7:+QNT3yxzQT8aXtyeLW4btLUOHt/CtnSaHmTOA4jLRG64Cleba9CQ31qIl80BNnT/lkb2bDEXwP71ZAxrG0hG082rVKmGzi9uxtzmjnWKWRBkAcddVYScs86U9Eg9FlTLjRlW3VUjna9KGgiaBI3UCsJrJ/omDdScHrvWxiOJaDEfWw/y3Ehz+Nc+i3QZhUTqR4oVu1UdJt5xHNYKZJ+bMUQA5ryoghuNlhvIX7Anydgm45ML732NMtJmMetdE/rhutzqhgmY2Iaz+kexOsXijnFRAynsTkJWspcPW0tKD9Am8aNHoE4ChbxSbLH+Lw4KdilofVwsVUv92FrOP1MCs7O2+x7rrFRqew7a/6Oq0iY= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2016 01:42:52.6610 (UTC) X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[217.140.96.140];Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB0567 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Will & Catalin, On Tue, Nov 08, 2016 at 04:36:43PM +0000, Will Deacon wrote: > On Tue, Nov 08, 2016 at 02:09:09PM +0000, Catalin Marinas wrote: > > On Tue, Nov 08, 2016 at 01:44:37PM +0800, Huang Shijie wrote: > > > (3) The test result in the Softiron and Juno-r1 boards: > > > > > > This detail test result shows below (both the "make func" & "make stress"): > > > > > > 4KB granule: > > > > > > 1.1) PTE + Contiguous bit : 4K x 16 = 64K (per huge page size) > > > Test result : PASS > > > > > > 1.2) PMD : 2M x 1 = 2M (per huge page size) > > > Test result : PASS > > > > > > 1.3) PMD + Contiguous bit : 2M x 16 = 32M (per huge page size) > > > Test result : PASS > > > > > > 64KB granule: > > > > > > 3.1) PTE + Contiguous bit : 64K x 32 = 2M (per huge page size) > > > Test result : PASS > > > > > > 3.2) PMD + Contiguous bit : 512M x 32 = 16G (per huge page size) > > > Test result : no hardware to support this test > > > > Don't we have support for single (non-contiguous) PMD huge page with 64K > > pages (512M per huge page)? I gave it a try and it seems to work (though > > without your patches applied ;)). Yes, it should be okay. This patch set does not affect the the single PMD huge page. > > > > > Huang Shijie (2): > > > arm64: hugetlb: remove the wrong pmd check in find_num_contig() > > > arm64: hugetlb: fix the wrong address for several functions > > > > For these patches: > > > > Reviewed-by: Catalin Marinas Thanks you, Catalin. > > > > I'm not sure whether Will plans to push them into 4.9. AFAICT, the > > contiguous huge pages never worked properly, so we may not count it as a > > regression but a new feature. If Will doesn't take them, I'll queue the > > patches for 4.10. > > Right, given that it's never worked and the failure only seems to crop up > in synthetic testing, I think you can queue these for 4.10. Okay. Thank for queue them for 4.10. Thanks Huang Shijie