mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Gayatri Kammela <gayatri.kammela@intel.com>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org, x86@kernel.org,
	"H . Peter Anvin" <hpa@linux.intel.com>,
	Ravi Shankar <ravi.v.shankar@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>
Subject: Re: [PATCH] x86/cpufeatures: Enable new AVX512 cpu features
Date: Wed, 9 Nov 2016 10:19:17 +0100	[thread overview]
Message-ID: <20161109091917.pj467vump6c2nzqm@pd.tnic> (raw)
In-Reply-To: <1478650124-22663-1-git-send-email-gayatri.kammela@intel.com>

On Tue, Nov 08, 2016 at 04:08:44PM -0800, Gayatri Kammela wrote:
> Modify cpufeatures.h to add new AVX512 instruction groups/features
> for enuermation in /proc/cpuinfo: AVX512IFMA and AVX512VBMI
> 
> Also modify the xstate.c to clear the flags in
> fpu__xstate_clear_all_cpu_caps().

This is already visible in the diff itself, no need to explain what the
patch does.

Also, please run your commit message through a spellchecker.

> CPUID.(EAX=7,ECX=0):EBX[bit 21] AVX512IFMA
> CPUID.(Eax=7,ECX=0):ECX[bit 1]  AVX512VBMI

s/Eax/EAX/

> Detailed information of cpuid bits for the features can be found in
> Intel Architecture Instruction Set Extensions Programming Reference.

We have recently started uploading such documents into
bugzilla.kernel.org in order to have a stable reference source, see

https://lkml.kernel.org/r/alpine.DEB.2.20.1611082002160.3501@nanos

Please do so too and add the link to the commit message.

Rest looks ok to me.

Thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

  reply	other threads:[~2016-11-09  9:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-09  0:08 Gayatri Kammela
2016-11-09  9:19 ` Borislav Petkov [this message]
2016-11-11 20:09   ` Kammela, Gayatri
2016-11-15 12:02     ` Borislav Petkov
  -- strict thread matches above, loose matches on Subject: below --
2017-10-20  0:08 Gayatri Kammela
2017-10-20  6:37 ` Thomas Gleixner
2016-10-22  0:15 Gayatri Kammela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161109091917.pj467vump6c2nzqm@pd.tnic \
    --to=bp@alien8.de \
    --cc=fenghua.yu@intel.com \
    --cc=gayatri.kammela@intel.com \
    --cc=hpa@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=ravi.v.shankar@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®