From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754793AbcKJJSO (ORCPT ); Thu, 10 Nov 2016 04:18:14 -0500 Received: from mail.skyhub.de ([78.46.96.112]:33750 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753306AbcKJJSM (ORCPT ); Thu, 10 Nov 2016 04:18:12 -0500 Date: Thu, 10 Nov 2016 10:18:09 +0100 From: Borislav Petkov To: Sebastian Andrzej Siewior Cc: "Luck, Tony" , "linux-kernel@vger.kernel.org" , "rt@linutronix.de" , "linux-edac@vger.kernel.org" , "x86@kernel.org" , Thomas Gleixner Subject: Re: [PATCH 22/25] x86/mcheck: Do the init in one place Message-ID: <20161110091809.vxyf3yiuxtjy3vqv@pd.tnic> References: <20161103145021.28528-1-bigeasy@linutronix.de> <20161103145021.28528-23-bigeasy@linutronix.de> <20161107184532.xj6wzdjlzwhshcmf@pd.tnic> <20161107185524.GA2536@intel.com> <20161107201224.7xazmhgm7bogkrw5@pd.tnic> <20161108092302.wraci5m2cxqozlew@pd.tnic> <20161109142221.3r6xwhkxbckuv3bh@linutronix.de> <20161109153807.7mv7b5f4oqfijq2h@pd.tnic> <3908561D78D1C84285E8C5FCA982C28F3A229E6C@ORSMSX114.amr.corp.intel.com> <20161110090037.apohiqnqgbymbq6j@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161110090037.apohiqnqgbymbq6j@linutronix.de> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 10, 2016 at 10:00:38AM +0100, Sebastian Andrzej Siewior wrote: > okay. So I had a discussion with Boris and we agreed that we don't do > the init part in one place only the timer stuff will be moved. > If I understand Tony correctly then we undo something in > vendor_disable_error_reporting() (on !INTEL CPUs) that we enable in > identify_cpu(). > > Boris, if my understanding is correct, what now? Do move the whole > hotplug init part to an earlier stage? Or do we drop > vendor_disable_error_reporting()? Nah, we proceed as we discussed it - let's move the timer only. The mce_gen_pool_init() allocation is not where it should be - it should run somewhere only once on CPU0 but I haven't found a better place yet so that the allocation succeeds - mind you, this is very early and gen_pool_create() uses kmalloc_node() which might not be functioning yet... Tony's point is showing that the hotplug notifiers don't do any bit clearing on Intel, i.e., basically we don't do anything on the CPU_DOWN_PREPARE path on Intel. Thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.