From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965012AbcKJTSc (ORCPT ); Thu, 10 Nov 2016 14:18:32 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:51616 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932259AbcKJTS3 (ORCPT ); Thu, 10 Nov 2016 14:18:29 -0500 Date: Thu, 10 Nov 2016 20:18:36 +0100 From: Greg Kroah-Hartman To: "Luis R. Rodriguez" Cc: Yves-Alexis Perez , "linux-kernel@vger.kernel.org" , Yves-Alexis Perez , Ming Lei , Johannes Berg , Jouni Malinen , Kees Cook , Jiri Kosina , Jiri Slaby , Tom Gundersen , Kay Sievers , Josh Boyer , Dmitry Torokhov , Andy Lutomirski , Harald Hoyer , Seth Forshee , Bjorn Andersson , Daniel Wagner , "4.2+" Subject: Re: [PATCH] firmware: fix async/manual firmware loading Message-ID: <20161110191836.GB4775@kroah.com> References: <20161030145048.6291-1-corsac@corsac.net> <20161030145048.6291-2-corsac@corsac.net> <20161109203921.GH13978@wotan.suse.de> <20161110155511.GA10806@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 10, 2016 at 08:07:58AM -0800, Luis R. Rodriguez wrote: > > It shouldn't be hard to figure out if a patch should be in stable or not... > > Well with the only caveat now that I am suggesting we consider remove > this logic completely as only 2 drivers were using it explicitly > (second argument to request_firmware_nowait() set to false), it seems > they had good reasons for it but ... this has been broken for ages and > we seem to be happy to compartamentalize the UMH further, its unclear > why we would want to expand and "fix" that instead of just removing > crap that never worked. Thoughts? Why would you want to remove stuff that works and people rely on? Don't be foolish, you know we can't do that... greg k-h