From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756086AbcKKIen (ORCPT ); Fri, 11 Nov 2016 03:34:43 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:47708 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754046AbcKKIem (ORCPT ); Fri, 11 Nov 2016 03:34:42 -0500 X-Greylist: delayed 325 seconds by postgrey-1.27 at vger.kernel.org; Fri, 11 Nov 2016 03:34:41 EST Date: Fri, 11 Nov 2016 09:34:37 +0100 From: Maxime Ripard To: Chen-Yu Tsai Cc: Linus Walleij , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 1/3] pinctrl: sunxi: Fix PIN_CONFIG_BIAS_PULL_{DOWN,UP} argument Message-ID: <20161111083437.i3iotrwpjvpzmi2h@lukather> References: <20161111024455.16883-1-wens@csie.org> <20161111024455.16883-2-wens@csie.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="attialspto4anlj6" Content-Disposition: inline In-Reply-To: <20161111024455.16883-2-wens@csie.org> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --attialspto4anlj6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 11, 2016 at 10:44:53AM +0800, Chen-Yu Tsai wrote: > According to pinconf-generic.h, the argument for > PIN_CONFIG_BIAS_PULL_{DOWN,UP} is non-zero if the bias is enabled > with a pull up/down resistor, zero if it is directly connected > to VDD or ground. >=20 > Since Allwinner hardware uses a weak pull resistor internally, > the argument should be 1. >=20 > Signed-off-by: Chen-Yu Tsai Acked-by: Maxime Ripard Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --attialspto4anlj6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYJYKZAAoJEBx+YmzsjxAgRp8P/12romeik6HNufxYJFydursv Is8gbAQsFwqihX84mwemro1c+HxAOX9po7nNIDy5DKVm66OakK02VejBgqLl58MD abww8XzX0vTuP/Ie8emJxKGEYZvwzkO1ZQ9XLmz6rj0eriRSSBrYglFNSMzR8B6l PMAmT0+u8/eSdj1WuKonEiAtTGnRFvwS+MyHjnMbCBHZmwvpG1ZaTL4sSHfwqIhm N42EGexUgnO3KuE0HU/2nGEu1sEjXQPKF1oA9WrdZDAxJ9+pA9c2cSeeyGZWlcfi DA5BHo0g48Fkxlr5jPijR9PTzE4qYxQR+cQ2eoNEyxF9mF7wpMQj3DtIkatSJBWa +H3Yvf7TWyjftSCenvl/ZsC2QpBijnjdsl5eXBZ7XuoWrZI3ed9LN/zaNY1NOTYN c7XZkvwSn2li9KO8msX5e8ApiNLEgvaPVxoXgozRxvFOC0j8TpqPesJRABDxX29P wuVhGS/GwYt1xu7gFuL8xXDT9klBf6c+Sha9RSeU/oZWPNG4x0gsqD3z9mf7g9oZ G6PKMn65LW4vMZ1jPheMGmc3jeLUrZsPT15YLLVCerUHyNUtWpqdYJ1YArJ9ONqm HSdhwdtOMNUMRGnKb9FSYi+gvQz3SjI9+e659Jydw2puF7nS4dojWUkjzLzjE0WP 5igGDYgpi+TbNmh1Sq5i =FPCf -----END PGP SIGNATURE----- --attialspto4anlj6--