From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756056AbcKKIi4 (ORCPT ); Fri, 11 Nov 2016 03:38:56 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:47860 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755482AbcKKIiy (ORCPT ); Fri, 11 Nov 2016 03:38:54 -0500 Date: Fri, 11 Nov 2016 09:38:52 +0100 From: Maxime Ripard To: Chen-Yu Tsai Cc: Linus Walleij , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 3/3] pinctrl: sunxi: Make sunxi_pconf_group_set use sunxi_pconf_reg helper Message-ID: <20161111083852.yacy33g6pag6ucon@lukather> References: <20161111024455.16883-1-wens@csie.org> <20161111024455.16883-4-wens@csie.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rlav2tu6pogzkwjr" Content-Disposition: inline In-Reply-To: <20161111024455.16883-4-wens@csie.org> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --rlav2tu6pogzkwjr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 11, 2016 at 10:44:55AM +0800, Chen-Yu Tsai wrote: > The sunxi_pconf_reg helper introduced in the last patch gives us the > chance to rework sunxi_pconf_group_set to have it match the structure > of sunxi_pconf_(group_)get and make it easier to understand. >=20 > For each config to set, it: >=20 > 1. checks if the parameter is supported. > 2. checks if the argument is within limits. > 3. converts argument to the register value. > 4. writes to the register with spinlock held. >=20 > As a result the function now blocks unsupported config parameters, > instead of silently ignoring them. >=20 > Signed-off-by: Chen-Yu Tsai Acked-by: Maxime Ripard But I think the config variable removal should be part of patch 2, as discussed there. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --rlav2tu6pogzkwjr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYJYOcAAoJEBx+YmzsjxAg6YoP/A0v2eYN8Cu06qLgR9u3OV8G TLEzCfK7Xo8kVNEt+X1Fcmm4gdcuQaRNEprbysIr6vgB6EH0aGKsHJRiIhq2jWuh 7Dg+V5YYC6dMJsv+QhQ0fRYwvSYprs837h6W7GCFlhUcX5xS57OLQrm9M1raWbl/ rYUwZtwqS1TqqnWUH0IpmVcycFl+9rcYGBnKQE53YFNwENJ2sST92OgGAGxvlLbq u9KVObnMhbukiokT7/KLKakZzaAZeSBxwumuhceRqFZT7aQfki8DOryzE6IJEtPJ AGpMLztV2+LI02jotKFuqyx0EE8nd0BwtYCweQwJJEeIvzGk+DeL/VJa0HoU4JdR oDFBQQvCivkf+cGkZnPzpf2y3hgKSjh6p5FEdygGiItuG69r4nPu9zPUjw2f5IUy GmISR+2yfUOs2UnzGncP3d8j++NDvFrGskrTBwlgkP4UAz0U+6RLd3SOFdOaI8ma enKLhf6yC9jU52HHKZY7iJ1GduE03xJEWU2H7NcunQ6ucJRBwl0fx8HltHUaFKte CF1DeNw5GogWVCwp5no9Nq7/bfSIkQmc+noZkg/4vhPiRIXdo7pgwpWjx8kdnaNR 7HPtVB4C56W7ILGntlylPPADJni6fRsLDCGIlRawq3RZysOHMR64BjpKy5kYn569 64sF48HQbVSEtcr7Qmat =828X -----END PGP SIGNATURE----- --rlav2tu6pogzkwjr--