From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937735AbcKKT5m (ORCPT ); Fri, 11 Nov 2016 14:57:42 -0500 Received: from mail.skyhub.de ([78.46.96.112]:36119 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933931AbcKKT5l (ORCPT ); Fri, 11 Nov 2016 14:57:41 -0500 Date: Fri, 11 Nov 2016 20:57:37 +0100 From: Borislav Petkov To: Sebastian Andrzej Siewior Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, rt@linutronix.de, Tony Luck , linux-edac@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 5/7] x86/mcheck: reorganize the hotplug callbacks Message-ID: <20161111195737.i2p35ax6km2ilcng@pd.tnic> References: <20161110091809.vxyf3yiuxtjy3vqv@pd.tnic> <20161110174447.11848-1-bigeasy@linutronix.de> <20161110174447.11848-6-bigeasy@linutronix.de> <20161111184453.ax5getrj5y3i4fuc@pd.tnic> <20161111193631.srv7sxqzykvymgbf@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161111193631.srv7sxqzykvymgbf@linutronix.de> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 11, 2016 at 08:36:31PM +0100, Sebastian Andrzej Siewior wrote: > __mcheck_cpu_init_timer() does not only prepare the timer but also fires > it. And __mcheck_cpu_init_timer() is invoked from other places and the > caller probably expects the timer to be fired. Then please do it right: static void __mcheck_cap_setup_timer(void) { struct timer_list *t = this_cpu_ptr(&mce_timer); unsigned int cpu = smp_processor_id(); setup_pinned_timer(t, mce_timer_fn, cpu); } and call that function then. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.