From: Jason Cooper <jason@lakedaemon.net>
To: Walt Feasel <waltfeasel@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [STYLE]staging:skein:threefish_block.c remove blank lines
Date: Sat, 12 Nov 2016 22:55:24 +0000 [thread overview]
Message-ID: <20161112225524.GD5329@io.lakedaemon.net> (raw)
In-Reply-To: <1478980973-2617-1-git-send-email-waltfeasel@gmail.com>
Hi Walt,
Thanks for the patch, unfortunately, it's a NAK. If you search the ml
archives, you'll see this has been addressed before.
On Sat, Nov 12, 2016 at 03:02:53PM -0500, Walt Feasel wrote:
> Made suggested modifications from checkpatch in reference
> to CHECK: Please don't use multiple blank lines
>
> Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
> ---
> drivers/staging/skein/threefish_block.c | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/drivers/staging/skein/threefish_block.c b/drivers/staging/skein/threefish_block.c
> index a95563f..5064065 100644
> --- a/drivers/staging/skein/threefish_block.c
> +++ b/drivers/staging/skein/threefish_block.c
> @@ -64,7 +64,6 @@ void threefish_encrypt_256(struct threefish_key *key_ctx, u64 *input,
> b2 += b1;
> b1 = rol64(b1, 32) ^ b2;
>
> -
The double lines are deliberate to show a logical separation between the
blocks of code. Ideally, the second blank line would be a comment
describing the following block. However, I'm not smart enough yet to
add correct comments. So, the blank lines remain. :-/
thx,
Jason.
> b1 += k3 + t2;
> b0 += b1 + k2;
> b1 = rol64(b1, 14) ^ b0;
> @@ -117,7 +116,6 @@ void threefish_encrypt_256(struct threefish_key *key_ctx, u64 *input,
> b2 += b1;
> b1 = rol64(b1, 32) ^ b2;
>
> -
> b1 += k0 + t1;
> b0 += b1 + k4;
> b1 = rol64(b1, 14) ^ b0;
> @@ -170,7 +168,6 @@ void threefish_encrypt_256(struct threefish_key *key_ctx, u64 *input,
> b2 += b1;
> b1 = rol64(b1, 32) ^ b2;
>
> -
> b1 += k2 + t0;
> b0 += b1 + k1;
> b1 = rol64(b1, 14) ^ b0;
> @@ -223,7 +220,6 @@ void threefish_encrypt_256(struct threefish_key *key_ctx, u64 *input,
> b2 += b1;
> b1 = rol64(b1, 32) ^ b2;
>
> -
> b1 += k4 + t2;
> b0 += b1 + k3;
> b1 = rol64(b1, 14) ^ b0;
> @@ -276,7 +272,6 @@ void threefish_encrypt_256(struct threefish_key *key_ctx, u64 *input,
> b2 += b1;
> b1 = rol64(b1, 32) ^ b2;
>
> -
> b1 += k1 + t1;
> b0 += b1 + k0;
> b1 = rol64(b1, 14) ^ b0;
> @@ -329,7 +324,6 @@ void threefish_encrypt_256(struct threefish_key *key_ctx, u64 *input,
> b2 += b1;
> b1 = rol64(b1, 32) ^ b2;
>
> -
> b1 += k3 + t0;
> b0 += b1 + k2;
> b1 = rol64(b1, 14) ^ b0;
> @@ -382,7 +376,6 @@ void threefish_encrypt_256(struct threefish_key *key_ctx, u64 *input,
> b2 += b1;
> b1 = rol64(b1, 32) ^ b2;
>
> -
> b1 += k0 + t2;
> b0 += b1 + k4;
> b1 = rol64(b1, 14) ^ b0;
> @@ -435,7 +428,6 @@ void threefish_encrypt_256(struct threefish_key *key_ctx, u64 *input,
> b2 += b1;
> b1 = rol64(b1, 32) ^ b2;
>
> -
> b1 += k2 + t1;
> b0 += b1 + k1;
> b1 = rol64(b1, 14) ^ b0;
> @@ -579,7 +571,6 @@ void threefish_decrypt_256(struct threefish_key *key_ctx, u64 *input,
> b2 -= b3 + k3 + t2;
> b3 -= k4 + 16;
>
> -
> tmp = b3 ^ b0;
> b3 = ror64(tmp, 32);
> b0 -= b3;
> @@ -648,7 +639,6 @@ void threefish_decrypt_256(struct threefish_key *key_ctx, u64 *input,
> b2 -= b3 + k1 + t0;
> b3 -= k2 + 14;
>
> -
> tmp = b3 ^ b0;
> b3 = ror64(tmp, 32);
> b0 -= b3;
> @@ -717,7 +707,6 @@ void threefish_decrypt_256(struct threefish_key *key_ctx, u64 *input,
> b2 -= b3 + k4 + t1;
> b3 -= k0 + 12;
>
> -
> tmp = b3 ^ b0;
> b3 = ror64(tmp, 32);
> b0 -= b3;
> @@ -786,7 +775,6 @@ void threefish_decrypt_256(struct threefish_key *key_ctx, u64 *input,
> b2 -= b3 + k2 + t2;
> b3 -= k3 + 10;
>
> -
> tmp = b3 ^ b0;
> b3 = ror64(tmp, 32);
> b0 -= b3;
> @@ -855,7 +843,6 @@ void threefish_decrypt_256(struct threefish_key *key_ctx, u64 *input,
> b2 -= b3 + k0 + t0;
> b3 -= k1 + 8;
>
> -
> tmp = b3 ^ b0;
> b3 = ror64(tmp, 32);
> b0 -= b3;
> @@ -924,7 +911,6 @@ void threefish_decrypt_256(struct threefish_key *key_ctx, u64 *input,
> b2 -= b3 + k3 + t1;
> b3 -= k4 + 6;
>
> -
> tmp = b3 ^ b0;
> b3 = ror64(tmp, 32);
> b0 -= b3;
> @@ -993,7 +979,6 @@ void threefish_decrypt_256(struct threefish_key *key_ctx, u64 *input,
> b2 -= b3 + k1 + t2;
> b3 -= k2 + 4;
>
> -
> tmp = b3 ^ b0;
> b3 = ror64(tmp, 32);
> b0 -= b3;
> @@ -1062,7 +1047,6 @@ void threefish_decrypt_256(struct threefish_key *key_ctx, u64 *input,
> b2 -= b3 + k4 + t0;
> b3 -= k0 + 2;
>
> -
> tmp = b3 ^ b0;
> b3 = ror64(tmp, 32);
> b0 -= b3;
> --
> 2.1.4
>
next prev parent reply other threads:[~2016-11-12 23:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-12 20:02 Walt Feasel
2016-11-12 22:55 ` Jason Cooper [this message]
2016-11-14 10:34 ` Dan Carpenter
2016-11-14 14:31 ` Greg KH
2016-11-15 20:39 ` Jason Cooper
2016-11-15 20:41 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161112225524.GD5329@io.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=waltfeasel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome