From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934543AbcKMREL (ORCPT ); Sun, 13 Nov 2016 12:04:11 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:43906 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753064AbcKMREK (ORCPT ); Sun, 13 Nov 2016 12:04:10 -0500 Date: Sun, 13 Nov 2016 12:03:49 -0500 (EST) Message-Id: <20161113.120349.394151836949728811.davem@davemloft.net> To: linux@roeck-us.net Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] r8152: Fix error path in open function From: David Miller In-Reply-To: <1478749885-32212-1-git-send-email-linux@roeck-us.net> References: <1478749885-32212-1-git-send-email-linux@roeck-us.net> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 13 Nov 2016 08:04:21 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Guenter Roeck Date: Wed, 9 Nov 2016 19:51:25 -0800 > If usb_submit_urb() called from the open function fails, the following > crash may be observed. ... > Clean up error handling to avoid registering the notifier if the open > function is going to fail. > > Signed-off-by: Guenter Roeck Looks good, applied, thanks.