From: Steve Muckle <smuckle.linux@gmail.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
Rafael Wysocki <rjw@rjwysocki.net>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Juri Lelli <Juri.Lelli@arm.com>,
Robin Randhawa <robin.randhawa@arm.com>
Subject: Re: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task
Date: Sun, 13 Nov 2016 11:31:59 -0800 [thread overview]
Message-ID: <20161113193159.GB29583@graphite.smuckle.net> (raw)
In-Reply-To: <CAJZ5v0jODn1gJtTtpTigA=7QwK04wzdFopr-R6GeoSchqgpgiQ@mail.gmail.com>
On Fri, Nov 11, 2016 at 11:16:59PM +0100, Rafael J. Wysocki wrote:
> > + struct sched_param param = { .sched_priority = 50 };
>
> I'd define a symbol for the 50. It's just one extra line of code ...
A minor point for sure, but in general what's the motivation for
defining symbols for things which are only used once? It makes it harder
to untangle and learn a piece of code IMO, having to jump to the
definitions of them to see what they are.
thanks,
Steve
next prev parent reply other threads:[~2016-11-13 19:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 10:22 [PATCH 0/3] " Viresh Kumar
2016-11-11 10:22 ` [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier Viresh Kumar
2016-11-11 14:19 ` Peter Zijlstra
2016-11-11 21:52 ` Rafael J. Wysocki
2016-11-11 22:55 ` Peter Zijlstra
2016-11-11 21:58 ` Rafael J. Wysocki
2016-11-12 5:19 ` Viresh Kumar
2016-11-13 14:46 ` Rafael J. Wysocki
2016-11-14 4:06 ` Viresh Kumar
2016-11-14 11:30 ` Viresh Kumar
2016-11-11 10:22 ` [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task Viresh Kumar
2016-11-11 14:32 ` Tommaso Cucinotta
2016-11-11 14:39 ` Peter Zijlstra
2016-11-12 5:22 ` Viresh Kumar
2016-11-14 9:22 ` Peter Zijlstra
2016-11-14 10:22 ` Viresh Kumar
2016-11-12 5:21 ` Viresh Kumar
2016-11-11 22:16 ` Rafael J. Wysocki
2016-11-12 1:31 ` Saravana Kannan
2016-11-12 5:27 ` Viresh Kumar
2016-11-14 5:37 ` Viresh Kumar
2016-11-13 14:37 ` Rafael J. Wysocki
2016-11-13 19:47 ` Steve Muckle
2016-11-13 22:44 ` Rafael J. Wysocki
2016-11-14 6:36 ` Viresh Kumar
2016-11-12 5:24 ` Viresh Kumar
2016-11-13 19:31 ` Steve Muckle [this message]
2016-11-11 10:22 ` [PATCH 3/3] cpufreq: schedutil: irq-work is used only in slow path Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161113193159.GB29583@graphite.smuckle.net \
--to=smuckle.linux@gmail.com \
--cc=Juri.Lelli@arm.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robin.randhawa@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome