From: Steven Rostedt <rostedt@goodmis.org>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Rabin Vincent <rabin.vincent@axis.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Rabin Vincent <rabinv@axis.com>
Subject: Re: [PATCH] ARM: ftrace: fix syscall name matching
Date: Mon, 14 Nov 2016 10:44:32 -0500 [thread overview]
Message-ID: <20161114104432.3bd2fb2c@gandalf.local.home> (raw)
In-Reply-To: <20161114104008.36e9c40d@gandalf.local.home>
On Mon, 14 Nov 2016 10:40:08 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> > Is this really safe? What guarantees that we can wind forward four
> > bytes here? If it's always safe, it needs a better comment than just
> > two words.
>
> I believe it is, but a comment would do well.
Also, the generic function that is called if the arch does not define
ARCH_HAS_SYSCALL_MATCH_SYM_NAME does this too.
return !strcmp(sym + 3, name + 3);
And looking at this, it really should be + 4 and not + 3, because it
doesn't match the comment above, where it says it can handle both
".SyS" and "SyS", but it doesn't handle ".SyS" compared to ".sys".
-- Steve
next prev parent reply other threads:[~2016-11-14 15:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 13:03 Rabin Vincent
2016-11-14 13:40 ` Russell King - ARM Linux
2016-11-14 15:40 ` Steven Rostedt
2016-11-14 15:44 ` Steven Rostedt [this message]
2016-11-15 15:18 ` Rabin Vincent
2016-11-15 10:17 ` [PATCHv2] " Rabin Vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161114104432.3bd2fb2c@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rabin.vincent@axis.com \
--cc=rabinv@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®