From: Andi Kleen <ak@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>,
Jin Yao <yao.jin@linux.intel.com>,
jolsa@kernel.org, Linux-kernel@vger.kernel.org,
kan.liang@intel.com
Subject: Re: [PATCH v4 0/6] perf report: Show branch flags/cycles in --branch-history callgraph view
Date: Mon, 14 Nov 2016 06:49:44 -0800 [thread overview]
Message-ID: <20161114144944.GA20031@tassilo.jf.intel.com> (raw)
In-Reply-To: <20161114143056.GD27058@kernel.org>
On Mon, Nov 14, 2016 at 11:30:56AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Oct 31, 2016 at 09:19:48AM +0800, Jin Yao escreveu:
> > v4: Update according to Andi's comments. The requirement is not displaying
> > the number of removed loops. It needs to display the average number of
> > iterations. It computes out the number of iterations by counting
> > the removed loops.
> >
> > v3: 1. Display the count for tsx abort, remove the abort percentage.
> >
> > 2. Since the branch history code has a loop detection that removes
> > small loops in util/machine.c:remove_loops(). It would be nice to
> > note how many loops were removed. So it adds the note on some
> > callchain entries.
> >
> > v2: Just a rebase to Arnaldo's perf/core branch, no functional changes.
>
> Andi, are you ok with this now? Can I have your Acked-by or Tested-by?
Yes it looks good to me now.
Acked-by: Andi Kleen <ak@linux.intel.com>
-Andi
prev parent reply other threads:[~2016-11-14 14:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 1:19 Jin Yao
2016-10-31 1:19 ` [PATCH v4 1/6] perf report: Add branch flag to callchain cursor node Jin Yao
2016-10-31 1:19 ` [PATCH v4 2/6] perf report: Create a symbol_conf flag for showing branch flag counting Jin Yao
2016-11-15 10:47 ` [tip:perf/core] " tip-bot for Jin Yao
2016-10-31 1:19 ` [PATCH v4 3/6] perf report: Caculate and return the " Jin Yao
2016-11-15 10:47 ` [tip:perf/core] perf report: Calculate " tip-bot for Jin Yao
2016-10-31 1:19 ` [PATCH v4 4/6] perf report: Show branch info in callchain entry for stdio mode Jin Yao
2016-11-14 16:34 ` Arnaldo Carvalho de Melo
2016-11-15 0:45 ` Jin, Yao
2016-11-15 10:48 ` [tip:perf/core] " tip-bot for Jin Yao
2016-10-31 1:19 ` [PATCH v4 5/6] perf report: Show branch info in callchain entry for browser mode Jin Yao
2016-11-15 10:49 ` [tip:perf/core] " tip-bot for Jin Yao
2016-10-31 1:19 ` [PATCH v4 6/6] perf report: Display columns Predicted/Abort/Cycles in --branch-history Jin Yao
2016-11-14 14:30 ` [PATCH v4 0/6] perf report: Show branch flags/cycles in --branch-history callgraph view Arnaldo Carvalho de Melo
2016-11-14 14:49 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161114144944.GA20031@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome