From: Oleg Nesterov <oleg@redhat.com>
To: Ingo Molnar <mingo@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Mike Galbraith <efault@gmx.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: hartsjc@redhat.com, vbendel@redhat.com, vlovejoy@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] sched/autogroup: a zombie thread must not use autogroup->tg
Date: Mon, 14 Nov 2016 19:58:17 +0100 [thread overview]
Message-ID: <20161114185817.GA15995@redhat.com> (raw)
In-Reply-To: <20161114184612.GA15968@redhat.com>
On 11/14, Oleg Nesterov wrote:
>
> +void sched_autogroup_exit_task(struct task_struct *p)
> +{
> + /*
> + * We are going to call exit_notify() and autogroup_move_group() can't
> + * see this thread after that: we can no longer use signal->autogroup.
> + * See the PF_EXITING check in task_wants_autogroup().
> + */
> + sched_move_task(p);
We only need it if task_group_is_autogroup(task_group(p)) but then this code
will need even more comments, lets keep it simple.
Oleg.
next prev parent reply other threads:[~2016-11-14 18:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 18:45 [PATCH 0/2] sched/autogroup: use-after-free fixes Oleg Nesterov
2016-11-14 18:46 ` [PATCH 1/2] sched/autogroup: autogroup_move_group() must never skip sched_move_task() Oleg Nesterov
2016-11-22 12:28 ` [tip:sched/urgent] sched/autogroup: Fix autogroup_move_group() to " tip-bot for Oleg Nesterov
2016-11-14 18:46 ` [PATCH 2/2] sched/autogroup: a zombie thread must not use autogroup->tg Oleg Nesterov
2016-11-14 18:58 ` Oleg Nesterov [this message]
2016-11-22 12:29 ` [tip:sched/urgent] sched/autogroup: Do not use autogroup->tg in zombie threads tip-bot for Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161114185817.GA15995@redhat.com \
--to=oleg@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=efault@gmx.de \
--cc=hartsjc@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vbendel@redhat.com \
--cc=vlovejoy@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome