From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965695AbcKOCNq (ORCPT ); Mon, 14 Nov 2016 21:13:46 -0500 Received: from mga11.intel.com ([192.55.52.93]:30214 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964788AbcKOCNo (ORCPT ); Mon, 14 Nov 2016 21:13:44 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,640,1473145200"; d="scan'208";a="786466487" Date: Mon, 14 Nov 2016 18:13:41 -0800 From: Jarkko Sakkinen To: Stephen Rothwell Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Nayna Jain Subject: Re: linux-next: build warning after merge of the tpmdd tree Message-ID: <20161115021341.7tt6acyumfueq2kf@intel.com> References: <20161115120107.35e7db48@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161115120107.35e7db48@canb.auug.org.au> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 15, 2016 at 12:01:07PM +1100, Stephen Rothwell wrote: > Hi Jarkko, > > After merging the tpmdd tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > drivers/char/tpm/tpm_of.c: In function 'read_log_of': > drivers/char/tpm/tpm_of.c:37:8: warning: 'np' may be used uninitialized in this function [-Wmaybe-uninitialized] > sizep = of_get_property(np, "linux,sml-size", NULL); > ^ > > Introduced by commit > > 4a45d9669ac1 ("tpm: replace of_find_node_by_name() with dev of_node property") > > This commit is just wrong :-( It really is. I'll drop it from my tree. > -- > Cheers, > Stephen Rothwell /Jarkko