From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965251AbcKOCxZ (ORCPT <rfc822;w@1wt.eu>);
        Mon, 14 Nov 2016 21:53:25 -0500
Received: from imap.thunk.org ([74.207.234.97]:37654 "EHLO imap.thunk.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933542AbcKOCxX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 14 Nov 2016 21:53:23 -0500
Date: Mon, 14 Nov 2016 21:53:20 -0500
From: "Theodore Ts'o" <tytso@mit.edu>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: linux-kernel@vger.kernel.org, adilger.kernel@dilger.ca,
        linux-ext4@vger.kernel.org, arnd@arndb.de, y2038@lists.linaro.org
Subject: Re: [RESEND] fs: ext4: Use current_time() for inode timestamps
Message-ID: <20161115025320.oax4e56om5zcjynt@thunk.org>
Mail-Followup-To: Theodore Ts'o <tytso@mit.edu>,
        Deepa Dinamani <deepa.kernel@gmail.com>,
        linux-kernel@vger.kernel.org, adilger.kernel@dilger.ca,
        linux-ext4@vger.kernel.org, arnd@arndb.de, y2038@lists.linaro.org
References: <1478889177-4107-1-git-send-email-deepa.kernel@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1478889177-4107-1-git-send-email-deepa.kernel@gmail.com>
User-Agent: NeoMutt/20161014 (1.7.1)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: tytso@thunk.org
X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 11, 2016 at 10:32:57AM -0800, Deepa Dinamani wrote:
> CURRENT_TIME_SEC and CURRENT_TIME are not y2038 safe.
> current_time() will be transitioned to be y2038 safe
> along with vfs.
> 
> current_time() returns timestamps according to the
> granularities set in the super_block.
> The granularity check in ext4_current_time() to call
> current_time() or CURRENT_TIME_SEC is not required.
> Use current_time() directly to obtain timestamps
> unconditionally, and remove ext4_current_time().
> 
> Quota files are assumed to be on the same filesystem.
> Hence, use current_time() for these files as well.
> 
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>

Thanks, applied.

					- Ted