From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933576AbcKOMSy (ORCPT ); Tue, 15 Nov 2016 07:18:54 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:34996 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753274AbcKOMSv (ORCPT ); Tue, 15 Nov 2016 07:18:51 -0500 From: Colin King To: Tom Lendacky , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] amd-xgbe: fix unsigned comparison against less than zero Date: Tue, 15 Nov 2016 12:18:42 +0000 Message-Id: <20161115121842.5774-1-colin.king@canonical.com> X-Mailer: git-send-email 2.10.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Comparing unsigned int ret to less than zero for an error status check is never true. Fix this by making ret a signed int. Reduce scope of ret too. Found with static analysis by CoverityScan, CID 1377750 Signed-off-by: Colin Ian King --- drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c index 4ba4332..168507e 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c @@ -2346,7 +2346,7 @@ static bool xgbe_phy_valid_speed(struct xgbe_prv_data *pdata, int speed) static int xgbe_phy_link_status(struct xgbe_prv_data *pdata, int *an_restart) { struct xgbe_phy_data *phy_data = pdata->phy_data; - unsigned int ret, reg; + unsigned int reg; *an_restart = 0; @@ -2365,7 +2365,8 @@ static int xgbe_phy_link_status(struct xgbe_prv_data *pdata, int *an_restart) if (phy_data->phydev) { /* Check external PHY */ - ret = phy_read_status(phy_data->phydev); + int ret = phy_read_status(phy_data->phydev); + if (ret < 0) return 0; -- 2.10.2