From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S966182AbcKOPdr (ORCPT <rfc822;w@1wt.eu>);
        Tue, 15 Nov 2016 10:33:47 -0500
Received: from mail-pg0-f66.google.com ([74.125.83.66]:36505 "EHLO
        mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965977AbcKOPdl (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 15 Nov 2016 10:33:41 -0500
Date: Wed, 16 Nov 2016 00:32:39 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Jiri Olsa <jolsa@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCHSET 0/7] perf sched: Introduce timehist command, again (v1)
Message-ID: <20161115153239.GB29740@danjae.aot.lge.com>
References: <20161114161243.15403-1-namhyung@kernel.org>
 <20161115064214.GB27089@gmail.com>
 <20161115065509.GB16821@danjae.aot.lge.com>
 <20161115073413.GA7016@gmail.com>
 <468ed743-a7e9-44e4-6fcc-5853ab49447e@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <468ed743-a7e9-44e4-6fcc-5853ab49447e@gmail.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi David,

On Tue, Nov 15, 2016 at 08:14:24AM -0700, David Ahern wrote:
> On 11/15/16 12:34 AM, Ingo Molnar wrote:
> > 
> > * Namhyung Kim <namhyung@kernel.org> wrote:
> > 
> >>>> By default it shows the individual schedule events, including the time between
> >>>> sched-in events for the task, the task scheduling delay (time between wakeup
> >>>> and actually running) and run time for the task:
> >>>>
> >>>>            time cpu  task name[tid/pid]    b/n time sch delay  run time
> >>>>   ------------- ---- -------------------- --------- --------- ---------
> >>>>    79371.874569 [11] gcc[31949]               0.014     0.000     1.148
> >>>>    79371.874591 [10] gcc[31951]               0.000     0.000     0.024
> >>>>    79371.874603 [10] migration/10[59]         3.350     0.004     0.011
> >>>>    79371.874604 [11] <idle>                   1.148     0.000     0.035
> >>>>    79371.874723 [05] <idle>                   0.016     0.000     1.383
> >>>>    79371.874746 [05] gcc[31949]               0.153     0.078     0.022
> >>>> ...
> >>>
> >>> What does the 'b/n' abbreviation stand for? 'Between'? Could we call the column 
> >>> 'sch wait' instead, or so?
> >>
> >> Looks better, or what about 'wait time'?
> > 
> > Works for me!
> 
> That column generically is time not running -- time between the last
> sched out and the current sched in. It could be expected (sleep,
> select, read, ...), waiting for a resource (disk I/O, mutex) or
> preemption.

Right.  Maybe it'd be better to show the prev_state as well to
identify the reason (roughly).

So, are you ok with the name 'wait time'?  My thinking is that they
are all waiting for something - timer, resource or cpu.

Thanks,
Namhyung

> 
> > 
> >> I'd go with the first option - simply adding arrows.  It's good enough to 
> >> identify each function IMHO.
> > 
> > Ok!
> 
> I'd prefer the arrows too for a default. Color can be an add-on option.