From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755724AbcKOPu5 (ORCPT ); Tue, 15 Nov 2016 10:50:57 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:44278 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751783AbcKOPuy (ORCPT ); Tue, 15 Nov 2016 10:50:54 -0500 Date: Tue, 15 Nov 2016 15:50:45 +0000 From: Russell King - ARM Linux To: Masahiro Yamada Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: cache-uniphier: include instead of Message-ID: <20161115155045.GX1041@n2100.armlinux.org.uk> References: <1478534334-15562-1-git-send-email-yamada.masahiro@socionext.com> <20161107161448.GJ1041@n2100.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161107161448.GJ1041@n2100.armlinux.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 07, 2016 at 04:14:48PM +0000, Russell King - ARM Linux wrote: > On Tue, Nov 08, 2016 at 12:58:54AM +0900, Masahiro Yamada wrote: > > Nothing in this header file depends on . > > Rather, should be included for -ENODEV. > > So how do we end up with a definition for u32? > > I think you need both these include files. I've noticed you haven't responded to the above. I've discarded the patch you've placed in the patch system in the hope of a replacement with this comment addressed. Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.