From: Arnd Bergmann <arnd@arndb.de>
To: Andreas Noever <andreas.noever@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Lukas Wunner <lukas@wunner.de>,
Matt Fleming <matt@codeblueprint.co.uk>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] thunderbolt: fix compile-test dependencies
Date: Tue, 15 Nov 2016 16:58:53 +0100 [thread overview]
Message-ID: <20161115155908.650902-1-arnd@arndb.de> (raw)
Building the Apple thunderbolt driver on non-x86 machines now produces
a harmless warning:
warning: (THUNDERBOLT) selects APPLE_PROPERTIES which has unmet direct dependencies (EFI && EFI_STUB && X86)
As there is no compile-time dependency to the Apple properties support,
we can make that 'select' statement conditional on the dependencies
of that driver.
Fixes: c9cc3aaa0281 ("thunderbolt: Use Device ROM retrieved from EFI")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/thunderbolt/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/thunderbolt/Kconfig b/drivers/thunderbolt/Kconfig
index 0056df7f3c09..4e7d92193b65 100644
--- a/drivers/thunderbolt/Kconfig
+++ b/drivers/thunderbolt/Kconfig
@@ -1,7 +1,8 @@
menuconfig THUNDERBOLT
tristate "Thunderbolt support for Apple devices"
+ depends on (EFI_STUB && X86) || COMPILE_TEST
depends on PCI
- select APPLE_PROPERTIES
+ select APPLE_PROPERTIES if (X86 && EFI_STUB)
select CRC32
help
Cactus Ridge Thunderbolt Controller driver
--
2.9.0
next reply other threads:[~2016-11-15 15:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 15:58 Arnd Bergmann [this message]
2016-11-15 16:21 ` Lukas Wunner
2016-11-17 10:00 ` Arnd Bergmann
2016-11-17 13:53 ` Lukas Wunner
[not found] ` <3694785.gp6vtA09eN@wuerfel>
2016-11-17 15:12 ` Lukas Wunner
2016-11-17 15:29 ` Arnd Bergmann
2016-11-17 16:18 ` Lukas Wunner
2016-11-17 16:36 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115155908.650902-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=andreas.noever@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®