From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753882AbcKRTEV (ORCPT ); Fri, 18 Nov 2016 14:04:21 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:39344 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752247AbcKRTES (ORCPT ); Fri, 18 Nov 2016 14:04:18 -0500 Date: Fri, 18 Nov 2016 14:04:16 -0500 (EST) Message-Id: <20161118.140416.729970601759105910.davem@davemloft.net> To: colin.king@canonical.com Cc: derek.chickles@caviumnetworks.com, satananda.burla@caviumnetworks.com, felix.manlunas@caviumnetworks.com, raghu.vatsavayi@caviumnetworks.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] liquidio CN23XX: check if PENDING bit is clear using logical and From: David Miller In-Reply-To: <20161118184532.5282-1-colin.king@canonical.com> References: <20161118184532.5282-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 18 Nov 2016 10:04:50 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Fri, 18 Nov 2016 18:45:32 +0000 > From: Colin Ian King > > the mbox state should be bitwise anded rather than logically anded > with OCTEON_MBOX_STATE_RESPONSE_PENDING. Fix this by using the > correct & operator instead of &&. > > Signed-off-by: Colin Ian King Dan Carpenter already submitted a fix for this.