From: David Miller <davem@davemloft.net>
To: tushar.n.dave@oracle.com
Cc: sparclinux@vger.kernel.org, chris.hyser@oracle.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] sunqe: Fix compiler warnings
Date: Fri, 18 Nov 2016 14:29:42 -0500 (EST) [thread overview]
Message-ID: <20161118.142942.620136274318885678.davem@davemloft.net> (raw)
In-Reply-To: <1476737820-29584-2-git-send-email-tushar.n.dave@oracle.com>
From: Tushar Dave <tushar.n.dave@oracle.com>
Date: Mon, 17 Oct 2016 13:56:59 -0700
> sunqe uses '__u32' for dma handle while invoking kernel DMA APIs,
> instead of using dma_addr_t. This hasn't caused any 'incompatible
> pointer type' warning on SPARC because until now dma_addr_t is of
> type u32. However, recent changes in SPARC ATU (iommu) enables 64bit
> DMA and therefore dma_addr_t becomes of type u64. This makes
> 'incompatible pointer type' warnings inevitable.
>
> e.g.
> drivers/net/ethernet/sun/sunqe.c: In function ‘qec_ether_init’:
> drivers/net/ethernet/sun/sunqe.c:883: warning: passing argument 3 of ‘dma_alloc_coherent’ from incompatible pointer type
> ./include/linux/dma-mapping.h:445: note: expected ‘dma_addr_t *’ but argument is of type ‘__u32 *’
> drivers/net/ethernet/sun/sunqe.c:885: warning: passing argument 3 of ‘dma_alloc_coherent’ from incompatible pointer type
> ./include/linux/dma-mapping.h:445: note: expected ‘dma_addr_t *’ but argument is of type ‘__u32 *’
>
> This patch resolves above compiler warnings.
>
> Signed-off-by: Tushar Dave <tushar.n.dave@oracle.com>
> Reviewed-by: chris hyser <chris.hyser@oracle.com>
Aplpied.
next prev parent reply other threads:[~2016-11-18 19:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 20:56 [PATCH 0/2] sparc/net: " Tushar Dave
2016-10-17 20:56 ` [PATCH 1/2] sunqe: " Tushar Dave
2016-11-18 19:29 ` David Miller [this message]
2016-10-17 20:57 ` [PATCH 2/2] sunbmac: Fix compiler warning Tushar Dave
2016-11-18 19:29 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2016-10-15 0:06 [PATCH 0/2] net: Fix compiler warnings Tushar Dave
2016-10-15 0:06 ` [PATCH 1/2] sunqe: " Tushar Dave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118.142942.620136274318885678.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chris.hyser@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=tushar.n.dave@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®