From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753387AbcKRNtw (ORCPT ); Fri, 18 Nov 2016 08:49:52 -0500 Received: from mail-oi0-f68.google.com ([209.85.218.68]:33363 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752232AbcKRNtu (ORCPT ); Fri, 18 Nov 2016 08:49:50 -0500 Date: Fri, 18 Nov 2016 07:49:45 -0600 From: Rob Herring To: John Youn Cc: Felipe Balbi , Christian Lamparter , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Mark Rutland , Greg Kroah-Hartman Subject: Re: [PATCH v3] usb: dwc2: add amcc,dwc-otg support Message-ID: <20161118134945.3cx5ciajp6pffys7@rob-hp-laptop> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 15, 2016 at 03:03:40PM -0800, John Youn wrote: > From: Christian Lamparter > > This patch adds support for the "amcc,usb-otg" device > which is found in the PowerPC Canyonlands' dts. > > The device definition was added by: > > commit c89b3458d8cc ("powerpc/44x: Add USB DWC DTS entry to Canyonlands > board") > > but without any driver support as the dwc2 driver wasn't available at > that time. > > Note: The system can't use the generic "snps,dwc2" compatible > because of the special ahbcfg configuration. The default > GAHBCFG_HBSTLEN_INCR4 of snps,dwc2 can cause a system hang > when the USB and SATA is used concurrently. > > Signed-off-by: Christian Lamparter > Signed-off-by: John Youn > --- > > Sorry, the previous one broke compilation. This fixes it. > > Regards, > John > > v3 [johnyoun]: > * Fixed compilation issue > > v2 [johnyoun]: > * Removed params struct > * Minor commit message formatting > > Documentation/devicetree/bindings/usb/dwc2.txt | 1 + > drivers/usb/dwc2/params.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt b/Documentation/devicetree/bindings/usb/dwc2.txt > index ad8f7ff..6c7c2bce 100644 > --- a/Documentation/devicetree/bindings/usb/dwc2.txt > +++ b/Documentation/devicetree/bindings/usb/dwc2.txt > @@ -12,6 +12,7 @@ Required properties: > - "lantiq,xrx200-usb": The DWC2 USB controller instance in Lantiq XRX SoCs; > - "amlogic,meson8b-usb": The DWC2 USB controller instance in Amlogic Meson8b SoCs; > - "amlogic,meson-gxbb-usb": The DWC2 USB controller instance in Amlogic S905 SoCs; > + - "amcc,dwc-otg": The DWC2 USB controller instance in AMCC Canyonlands 460EX SoCs; > - snps,dwc2: A generic DWC2 USB controller with default parameters. > - reg : Should contain 1 register range (address and length) > - interrupts : Should contain 1 interrupt > diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c > index 513556a..a786256 100644 > --- a/drivers/usb/dwc2/params.c > +++ b/drivers/usb/dwc2/params.c > @@ -239,6 +239,7 @@ const struct of_device_id dwc2_of_match_table[] = { > { .compatible = "samsung,s3c6400-hsotg", .data = NULL}, > { .compatible = "amlogic,meson8b-usb", .data = ¶ms_amlogic }, > { .compatible = "amlogic,meson-gxbb-usb", .data = ¶ms_amlogic }, > + { .compatible = "amcc,dwc-otg", .data = NULL }, '.data = NULL' is unnecessary. With that fixed, Acked-by: Rob Herring > {}, > }; > MODULE_DEVICE_TABLE(of, dwc2_of_match_table); > -- > 2.10.0 >