From: Rui Miguel Silva <rmfrfs@gmail.com>
To: Rahul Krishnan <mrahul.krishnan@gmail.com>
Cc: elder@kernel.org, johan@kernel.org, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: staging: Greybus: Remove unnecessary braces for single statement block
Date: Fri, 18 Nov 2016 15:30:40 +0000 [thread overview]
Message-ID: <20161118153040.GA9364@arch-late.localdomain> (raw)
In-Reply-To: <20161118151525.GA6732@rahul>
Hi Rahul,
Thanks for the patch.
Now looks great.
On Fri, Nov 18, 2016 at 08:45:25PM +0530, Rahul Krishnan wrote:
>This patch fixes the following checkpath.pl warning
>WARNING: braces {} are not necessary for single statement blocks
>
>
>Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com>
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
>---
> drivers/staging/greybus/sdio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
>index 5649ef1..66b37ea 100644
>--- a/drivers/staging/greybus/sdio.c
>+++ b/drivers/staging/greybus/sdio.c
>@@ -191,9 +191,8 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
> state_changed = 1;
> }
>
>- if (event & GB_SDIO_WP) {
>+ if (event & GB_SDIO_WP)
> host->read_only = true;
>- }
>
> if (state_changed) {
> dev_info(mmc_dev(host->mmc), "card %s now event\n",
>--
>2.10.2
>
next prev parent reply other threads:[~2016-11-18 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 15:15 Rahul Krishnan
2016-11-18 15:30 ` Rui Miguel Silva [this message]
2016-11-21 4:08 ` Viresh Kumar
-- strict thread matches above, loose matches on Subject: below --
2016-11-15 13:24 Rahul Krishnan
2016-11-15 13:26 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118153040.GA9364@arch-late.localdomain \
--to=rmfrfs@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mrahul.krishnan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®