From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752806AbcKRQBl (ORCPT ); Fri, 18 Nov 2016 11:01:41 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:56273 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799AbcKRQBj (ORCPT ); Fri, 18 Nov 2016 11:01:39 -0500 From: Arnd Bergmann To: Jiri Pirko , Ido Schimmel Cc: Arnd Bergmann , "David S. Miller" , Ivan Vecera , Elad Raz , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] mlxsw: switchib: add MLXSW_PCI dependency Date: Fri, 18 Nov 2016 17:01:14 +0100 Message-Id: <20161118160127.473555-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:MrbcIOMecP2mYd5lUgDCpFjHJPtepHyNvOPtP7KeVMeVNmvZ6GC IiKZmL5YO3aiq9H3mkNyMSbn9FPnzDs5DZqXyqhJZGzl9qjxO8B/jQsM8cskdBT5U3ro2To QLUIRKN7l3F+8EebpmEZ1V4c/3AlnAuyQUpHdJjZAgwOwHICO286lJGN+pbTY3imeVYaFA1 68jiwrUwUEtP/KbQwCd/Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:CYYiQRHXgwY=:Tm2jAjWJAwoCj7TdbBjt+Y DswV5vA3PpJebByQP0S2TtIm6DYBl0zP8xON/5RfbPh96kN2GzB6bMdXh+bEMPApK3CkCvX+Q Rs2NYtlPO+7VNrm2rBkX14ItMM7nxn2EqlxA6ojjmW77EIMz34xDf6/r3ezqfwPCVXWoGOPmS 8paM69/rRAeF7N+AEpQFH5Hxyw5MIQjNxl9FaS8Zao1eT9XgsoB/ZFfT7sZtOQdEHnz8EJJ2D HMIHtVE1m5Z0ABYZFK0eKA0Xr6qqqDqjzxAIJQCl/WkEB53ZvLzPvQeIiLOUQSDzKuLhTkyHE QYNFvHnfA8+Z5d0biyxl7ghYZxjmkKMjGKr05iuE3TTB8W9//TMsibVylaXxbUZszF2aQ6w5p H0YuuvjkATCGU6L+utNo+6qi1JaqrQ0SPZjW/XPLd1BK5kSbJa9UHgw4gxXKFydGVTfy3Mdi9 7eS9J0nw3Ytm9Z+B6YfWv89sxbroMNji8IAe5Sjo6IOdR986krlRZ/g/O8fUKs23hjCH3oV2T stUXKhRLcAQvHpBTR4R9scX6PpBkVEilsvY6wyThbRo81X/6OS7h8w1ldNRgsSbmbNXUmNo26 prJmOvzJ3WxAi9+7+bAYdDk6MhFdes4Q/LQLPz7feyil6U7yhny3kV3qcT7T1NEvCmFqejcSu fsk6qlL8f5F7A3udiGVGnxbrK9NIkPwzHqCZz+YCZIjPSn7I0OVaabeDCiKOYN1eJDWI= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The newly added switchib driver fails to link if MLXSW_PCI=m: drivers/net/ethernet/mellanox/mlxsw/mlxsw_switchib.o: In function^Cmlxsw_sib_module_exit': switchib.c:(.exit.text+0x8): undefined reference to `mlxsw_pci_driver_unregister' switchib.c:(.exit.text+0x10): undefined reference to `mlxsw_pci_driver_unregister' drivers/net/ethernet/mellanox/mlxsw/mlxsw_switchib.o: In function `mlxsw_sib_module_init': switchib.c:(.init.text+0x28): undefined reference to `mlxsw_pci_driver_register' switchib.c:(.init.text+0x38): undefined reference to `mlxsw_pci_driver_register' switchib.c:(.init.text+0x48): undefined reference to `mlxsw_pci_driver_unregister' The other two such sub-drivers have a dependency, so add the same one here. In theory we could allow this driver if MLXSW_PCI is disabled, but it's probably not worth it. Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/mellanox/mlxsw/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/Kconfig b/drivers/net/ethernet/mellanox/mlxsw/Kconfig index bac2e5e826e2..49237a24605e 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/Kconfig +++ b/drivers/net/ethernet/mellanox/mlxsw/Kconfig @@ -31,7 +31,7 @@ config MLXSW_PCI config MLXSW_SWITCHIB tristate "Mellanox Technologies SwitchIB and SwitchIB-2 support" - depends on MLXSW_CORE && NET_SWITCHDEV + depends on MLXSW_CORE && MLXSW_PCI && NET_SWITCHDEV default m ---help--- This driver supports Mellanox Technologies SwitchIB and SwitchIB-2 -- 2.9.0