From: Arnd Bergmann <arnd@arndb.de>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Guenter Roeck <groeck@chromium.org>,
Frank Wang <frank.wang@rock-chips.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] phy: rockchip-inno-usb2: add extcon dependency
Date: Fri, 18 Nov 2016 17:36:26 +0100 [thread overview]
Message-ID: <20161118163704.1236495-1-arnd@arndb.de> (raw)
If extcon is a loadable module and rockchip-inno-usb2 is built-in,
we get a link failure:
drivers/phy/phy-rockchip-inno-usb2.o: In function `rockchip_usb2phy_probe':
phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x1ec): undefined reference to `extcon_get_edev_by_phandle'
phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x25c): undefined reference to `devm_extcon_dev_allocate'
phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x2a8): undefined reference to `devm_extcon_dev_register'
phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0xa28): undefined reference to `extcon_register_notifier'
Adding a hard dependency avoids the problem. Alternatively we could
use "depends on EXTCON || !EXTCON" to allow building with extcon
disabled completely, but the other PHY drivers with extcon support
also just have a dependency, so this is more consistent.
Fixes: 0c42fe48fd23 ("phy: rockchip-inno-usb2: support otg-port for rk3399")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/phy/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 53cab9f3323b..b135ff1ab12d 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -366,6 +366,7 @@ config PHY_ROCKCHIP_INNO_USB2
depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
depends on COMMON_CLK
depends on USB_SUPPORT
+ depends on EXTCON
select GENERIC_PHY
select USB_COMMON
help
--
2.9.0
next reply other threads:[~2016-11-18 16:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 16:36 Arnd Bergmann [this message]
2016-11-18 21:23 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118163704.1236495-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=felipe.balbi@linux.intel.com \
--cc=frank.wang@rock-chips.com \
--cc=groeck@chromium.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®