Re: [PATCH] x86/dumpstack: make stack name tags more comprehensible

[Peter Zijlstra <peterz@infradead.org>]

On Fri, Nov 18, 2016 at 11:46:23AM -0600, Josh Poimboeuf wrote:
> NMI stack dumps are bracked by the following tags:
> 
>   <NMI>
>   ...
>   <EOE>
> 
> The ending tag is kind of confusing if you don't already know what "EOE"
> means (end of exception).  The same ending tag is also used to mark the
> end of all other exceptions' stacks.  For example:
> 
>   <#DF>
>   ...
>   <EOE>
> 
> And similarly, "EOI" is used as the ending tag for interrupts:
> 
>   <IRQ>
>   ...
>   <EOI>
> 
> Change the tags to be more comprehensible by making them symmetrical and
> more XML-esque:
> 
>   <NMI>
>   ...
>   </NMI>
> 
>   <#DF>
>   ...
>   </#DF>
> 
>   <IRQ>
>   ...
>   </IRQ>
> 
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>

>  arch/x86/include/asm/stacktrace.h |  3 +--
>  arch/x86/kernel/dumpstack.c       | 12 ++++++------
>  arch/x86/kernel/dumpstack_32.c    | 19 ++++++++-----------
>  arch/x86/kernel/dumpstack_64.c    | 22 ++++++++--------------
>  4 files changed, 23 insertions(+), 33 deletions(-)

And saves lines too, awesome!

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>