From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753299AbcKSPsQ (ORCPT ); Sat, 19 Nov 2016 10:48:16 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:34440 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752985AbcKSPsO (ORCPT ); Sat, 19 Nov 2016 10:48:14 -0500 Date: Sat, 19 Nov 2016 10:48:12 -0500 (EST) Message-Id: <20161119.104812.1434195314137737490.davem@davemloft.net> To: vijay.ac.kumar@oracle.com Cc: sparclinux@vger.kernel.org, karl.volz@oracle.com, rob.gardner@oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] sparc64: Migrate hvcons irq to panicked cpu From: David Miller In-Reply-To: <1478887919-10361-3-git-send-email-vijay.ac.kumar@oracle.com> References: <1478887919-10361-1-git-send-email-vijay.ac.kumar@oracle.com> <1478887919-10361-3-git-send-email-vijay.ac.kumar@oracle.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 19 Nov 2016 06:48:46 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vijay Kumar Date: Fri, 11 Nov 2016 10:11:57 -0800 > @@ -1444,8 +1444,12 @@ void smp_send_stop(void) > int cpu; > > if (tlb_type == hypervisor) { > + int this_cpu = smp_processor_id(); > + > + sunhv_migrate_hvcons_irq(this_cpu); > + You can't unconditionally call into code that might be configured out by a Kconfig option, as you are doing here. If SERIAL_SUNHV=n this change will thus result in a build error.