From: Guenter Roeck <linux@roeck-us.net>
To: Clemens Gruber <clemens.gruber@pqgruber.com>
Cc: linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [v3,3/3] hwmon: (mcp3021) replace S_IRUGO with 0444
Date: Sat, 19 Nov 2016 08:29:45 -0800 [thread overview]
Message-ID: <20161119162945.GA15441@roeck-us.net> (raw)
In-Reply-To: <20161109171614.9730-2-clemens.gruber@pqgruber.com>
On Wed, Nov 09, 2016 at 06:16:14PM +0100, Clemens Gruber wrote:
> Replace S_IRUGO with the better readable 0444.
> This fixes a checkpatch warning.
>
> Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
Applied to -next.
Guenter
> ---
> drivers/hwmon/mcp3021.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/mcp3021.c b/drivers/hwmon/mcp3021.c
> index 81f4b7f..3a007ab 100644
> --- a/drivers/hwmon/mcp3021.c
> +++ b/drivers/hwmon/mcp3021.c
> @@ -102,7 +102,7 @@ static ssize_t show_in_input(struct device *dev, struct device_attribute *attr,
> return sprintf(buf, "%d\n", in_input);
> }
>
> -static DEVICE_ATTR(in0_input, S_IRUGO, show_in_input, NULL);
> +static DEVICE_ATTR(in0_input, 0444, show_in_input, NULL);
>
> static int mcp3021_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
next prev parent reply other threads:[~2016-11-19 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 17:16 [PATCH v3 1/3] hwmon: (mcp3021) add devicetree support Clemens Gruber
2016-11-09 17:16 ` [PATCH v3 3/3] hwmon: (mcp3021) replace S_IRUGO with 0444 Clemens Gruber
2016-11-19 16:29 ` Guenter Roeck [this message]
2016-11-09 19:32 ` [PATCH v3 1/3] hwmon: (mcp3021) add devicetree support Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161119162945.GA15441@roeck-us.net \
--to=linux@roeck-us.net \
--cc=clemens.gruber@pqgruber.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®