From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <thierry.reding@gmail.com>, <lee.jones@linaro.org>
Cc: <tomi.valkeinen@ti.com>, <linux-pwm@vger.kernel.org>,
<linux-fbdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<p.zabel@pengutronix.de>
Subject: [PATCH v4 2/2] backlight: pwm_bl: Check the PWM state for initial backlight power state
Date: Tue, 22 Nov 2016 15:41:23 +0200 [thread overview]
Message-ID: <20161122134123.1209-3-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <20161122134123.1209-1-peter.ujfalusi@ti.com>
If the PWM is not enabled the backlight initially should not be enabled
either if we have booted with DT and there is a phandle pointing to the
backlight node.
The patch extends the checks to decide if we should keep the backlight off
initially.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Thierry Reding <treding@nvidia.com>
---
drivers/video/backlight/pwm_bl.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index 5712ddd053dd..d7efcb632f7d 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -215,6 +215,10 @@ static int pwm_backlight_initial_power_state(const struct pwm_bl_data *pb)
if (!regulator_is_enabled(pb->power_supply))
return FB_BLANK_POWERDOWN;
+ /* The PWM is disabled, keep it like this */
+ if (!pwm_is_enabled(pb->pwm))
+ return FB_BLANK_POWERDOWN;
+
return FB_BLANK_UNBLANK;
}
--
2.11.0.rc2
next prev parent reply other threads:[~2016-11-22 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 13:41 [PATCH v4 0/2] backlight: pwm_bl: Fix the initial power state selection Peter Ujfalusi
2016-11-22 13:41 ` [PATCH v4 1/2] backlight: pwm_bl: Move the checks for initial power state to a separate function Peter Ujfalusi
2016-12-09 9:13 ` Lee Jones
2017-03-21 18:48 ` Geert Uytterhoeven
2017-03-22 10:46 ` Philipp Zabel
2017-03-22 12:30 ` Geert Uytterhoeven
2016-11-22 13:41 ` Peter Ujfalusi [this message]
2016-12-09 9:14 ` [PATCH v4 2/2] backlight: pwm_bl: Check the PWM state for initial backlight power state Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122134123.1209-3-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®