From: Andre Noll <maan@tuebingen.mpg.de>
To: Eric Dumazet <edumazet@google.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>,
Yibin Yang <yibyang@cisco.com>,
Alexander Duyck <alexander.h.duyck@intel.com>,
Willem de Bruijn <willemb@google.com>,
Alexei Starovoitov <ast@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: Linux 4.4.34
Date: Tue, 22 Nov 2016 18:38:56 +0100 [thread overview]
Message-ID: <20161122173856.GC19939@tuebingen.mpg.de> (raw)
In-Reply-To: <CANn89iJCkHxOpE3TW8+gW8+UCVvT0mY8y8j_GJC1GK0i05dgbg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
On Tue, Nov 22, 09:14, Eric Dumazet wrote
> We definitely want to fix the real bug, not working around it.
>
> Seems an aliasing problem, key_control and key_basic might point to
> adjacent memory
> and a barrier() would solve the issue as well.
This was also my first idea. I added some printk statements
which confirmed that key_basic->n_proto, key_basic->ip_proto and
key_control->thoff were indeed close to each other. They did not
overlap though.
Hope this helps
Andre
--
Max Planck Institute for Developmental Biology
Spemannstraße 35, 72076 Tübingen, Germany. Phone: (+49) 7071 601 829
http://people.tuebingen.mpg.de/maan/
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2016-11-22 17:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 9:28 Greg KH
2016-11-21 9:28 ` Greg KH
2016-11-22 16:59 ` Andre Noll
2016-11-22 17:06 ` Greg KH
2016-11-22 17:14 ` Eric Dumazet
2016-11-22 17:38 ` Andre Noll [this message]
2016-11-22 17:41 ` Duyck, Alexander H
2016-11-22 17:46 ` Eric Dumazet
2016-11-22 17:55 ` Andre Noll
2016-11-22 17:56 ` Eric Dumazet
2016-11-22 18:03 ` Duyck, Alexander H
2016-11-22 18:06 ` Andre Noll
2016-11-22 18:08 ` Duyck, Alexander H
2016-11-22 18:18 ` Eric Dumazet
2016-11-22 18:22 ` Andre Noll
2016-11-22 19:17 ` [PATCH net] flow_dissect: call init_default_flow_dissectors() earlier Eric Dumazet
2016-11-22 19:44 ` Andre Noll
2016-11-22 19:44 ` David Miller
2016-11-22 17:22 ` Linux 4.4.34 Andre Noll
2016-11-22 17:26 ` Eric Dumazet
2016-11-22 17:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122173856.GC19939@tuebingen.mpg.de \
--to=maan@tuebingen.mpg.de \
--cc=alexander.h.duyck@intel.com \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=willemb@google.com \
--cc=yibyang@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®