From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933920AbcKVVSq (ORCPT ); Tue, 22 Nov 2016 16:18:46 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:60990 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755827AbcKVVSm (ORCPT ); Tue, 22 Nov 2016 16:18:42 -0500 Message-Id: <20161122210518.079483154@linutronix.de> User-Agent: quilt/0.63-1 Date: Tue, 22 Nov 2016 21:15:56 -0000 From: Thomas Gleixner To: LKML Cc: Rafael Wysocki , x86@kernel.org, Peter Zijlstra , linux-pm@vger.kernel.org, Srinivas Pandruvada , Jacob Pan Subject: [patch 0/5] powercap/intel_rapl: Fixes, hotplug conversion and simplifcation Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver fails to: - initialize packages which are not available at driver init time, though the value of that initialization is completely unclear as nothing ever uses these values. I fixed it up nevertheless and leave it to the maintainers to decide whether it should completely go away. - to propagate error codes in the hotplug online path, where a registration fails and the package data is freed, but return code is 0. The initialization/removal code of that driver is a maze of duplicated code which is more or less the same as the cpu hotplug code. After switching over the driver to the hotplug statemachine, the whole init/removal machinery can be replaced by installing/removing the hotplug state. The total damage is: intel_rapl.c | 363 ++++++++++++++++------------------------------------------- 1 file changed, 104 insertions(+), 259 deletions(-) and the binary size shrinks as well: text data bss dec hex 7996 625 32 8653 21cd Before 7216 593 32 7841 1ea1 After Thanks, tglx