From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935129AbcKVWqZ (ORCPT ); Tue, 22 Nov 2016 17:46:25 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:36593 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935064AbcKVWqS (ORCPT ); Tue, 22 Nov 2016 17:46:18 -0500 Date: Tue, 22 Nov 2016 14:46:15 -0800 From: Brian Norris To: Joe Perches Cc: Colin King , David Woodhouse , Boris Brezillon , Marek Vasut , Richard Weinberger , Cyrille Pitchen , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: mtdswap: fix spelling mistake "erassure" -> "erasure" Message-ID: <20161122224615.GJ77253@google.com> References: <20161028182559.7887-1-colin.king@canonical.com> <1477680707.7945.13.camel@perches.com> <20161122193753.GG77253@google.com> <1479850347.1942.24.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1479850347.1942.24.camel@perches.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 22, 2016 at 01:32:27PM -0800, Joe Perches wrote: > On Tue, 2016-11-22 at 11:37 -0800, Brian Norris wrote: > > Thanks, these all look good but: > > > > (a) you didn't provide a Signed-off-by and > > (b) your patch is full of non-breaking spaces (0xA0), instead of proper > > ASCII spaces (0x20) > > > > I feel like we've had this conversation before about your Evolution > > mailer a long time ago; you still haven't fixed that? > > > > I'm sorry, but I just can't take your patch. I'm not going to hand-edit > > this one... > > No worries, it was an unsigned patch suggestion, not > a formal patch. I know the difference. OK, understood. > And have you ever looked at the evolution source code? > At best, it's pretty convoluted. > There's _no way_ I want to touch it. I haven't looked. But by "fixed" I guess I meant "fixed your workflow" :) Regards, Brian