From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Michael Holzheu <holzheu@linux.vnet.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Zvonko Kosic <zvonko.kosic@de.ibm.com>,
linux-kernel@vger.kernel.org,
Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH] bpf/samples: Fix PT_REGS_IP on s390x and use it
Date: Wed, 23 Nov 2016 18:24:28 -0800 [thread overview]
Message-ID: <20161124022427.GA54828@ast-mbp.thefacebook.com> (raw)
In-Reply-To: <20161123162839.3f355b92@TP-holzheu>
On Wed, Nov 23, 2016 at 04:28:39PM +0100, Michael Holzheu wrote:
> The files "sampleip_kern.c" and "trace_event_kern.c" directly access
> "ctx->regs.ip" which is not available on s390x. Fix this and use the
> PT_REGS_IP() macro instead.
>
> Besides of that also fix the macro for s390x and use psw.addr from pt_regs.
>
> Reported-by: Zvonko Kosic <zvonko.kosic@de.ibm.com>
> Signed-off-by: Michael Holzheu <holzheu@linux.vnet.ibm.com>
Looks good.
Acked-by: Alexei Starovoitov <ast@kernel.org>
Please resubmit it to net-next and cc Dave.
note that my @plumgrid email no longer vaid.
prev parent reply other threads:[~2016-11-24 2:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 15:28 Michael Holzheu
2016-11-24 2:24 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124022427.GA54828@ast-mbp.thefacebook.com \
--to=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=heiko.carstens@de.ibm.com \
--cc=holzheu@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=zvonko.kosic@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome