From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752288AbcKYVLc (ORCPT ); Fri, 25 Nov 2016 16:11:32 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:52434 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbcKYVLX (ORCPT ); Fri, 25 Nov 2016 16:11:23 -0500 Date: Fri, 25 Nov 2016 16:10:58 -0500 (EST) Message-Id: <20161125.161058.2283539123524395654.davem@davemloft.net> To: colin.king@canonical.com Cc: hariprasad@chelsio.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cxgb4: fix memory leak on txq_info From: David Miller In-Reply-To: <20161123110244.16111-1-colin.king@canonical.com> References: <20161123110244.16111-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 25 Nov 2016 12:11:35 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Wed, 23 Nov 2016 11:02:44 +0000 > From: Colin Ian King > > Currently if txq_info->uldtxq cannot be allocated then > txq_info->txq is being kfree'd (which is redundant because it > is NULL) instead of txq_info. Fix this by instead kfree'ing > txq_info. > > Signed-off-by: Colin Ian King Applied, but Colin you _really_ need to start properly marking your networking patch submissions by indicating in the subject which tree your change is for. In this case I figured out it was net-next, but you must say this explicitly in the Subject line via "Subject: [PATCH net-next] ..." Thanks.